Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Angular] Upgrade to v17 #1837

Merged
merged 9 commits into from
Jul 17, 2024
Merged

[Angular] Upgrade to v17 #1837

merged 9 commits into from
Jul 17, 2024

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Jul 16, 2024 •
edited
Loading

Description / Motivation

  • Update Angular and core dependencies to ~17.3.11
  • Updated Typescript to ~5.2.2
  • Update zone.js/dist/zone-node to zone.js

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team July 16, 2024 20:39
yavorsk
yavorsk approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are zone.js imports in templates\angular\src\tests.ts should we update those too?
otherwise looks good to me!

illiakovalenko
illiakovalenko approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved with few comments

@illiakovalenko illiakovalenko merged commit fbaa342 into dev Jul 17, 2024
1 check was pending
@illiakovalenko illiakovalenko deleted the feature/jss-1538-angular-17 branch July 17, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

@yavorsk yavorsk yavorsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addy-pathania @yavorsk @illiakovalenko @apathania22