Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Next.js] FEAAS / BYOC Components are not visible on the page with running A/B test #1914

Merged
merged 3 commits into from
Aug 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ Our versioning strategy is as follows:

### 🐛 Bug Fixes

* `[templates/nextjs]` `[XM Cloud]` FEAAS / BYOC Components are not visible on the page with running A/B test ([#1914](https://github.com/Sitecore/jss/pull/1914))
* Make sure to update the _PagePropsFactory_ plugins *order*, these plugins should be executed after the _page-props-factory\plugins\personalize.ts_ plugin to ensure that personalized layout data is used:
- _page-props-factory/plugins/component-themes.ts_
- _page-props-factory/plugins/component-props.ts_
* `[sitecore-jss-nextjs]` Resolved an issue with redirects that was caused by the x-middleware-next header in Next.js. This header prevented the flow from being interrupted properly, resulting in redirects not functioning correctly in certain cases. ([#1899](https://github.com/Sitecore/jss/pull/1899))

## 22.1.1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import { Plugin } from '..';
import config from 'temp/config';

class ComponentThemesPlugin implements Plugin {
order = 2;
// Make sure to run this plugin after the personalization plugin, since it relies on the layout data
order = 10;

async exec(props: SitecorePageProps) {
// Collect FEAAS, BYOC, SXA component themes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ import { Plugin, isServerSidePropsContext } from '..';
class ComponentPropsPlugin implements Plugin {
private componentPropsService: ComponentPropsService;

order = 2;
// Make sure to run this plugin last to ensure that the updated layout data is used
order = 10;

constructor() {
this.componentPropsService = new ComponentPropsService();
Expand Down