Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next.js] sitemap.xml endpoint returns 404 #2023

Merged
merged 4 commits into from
Jan 28, 2025
Merged

[Next.js] sitemap.xml endpoint returns 404 #2023

merged 4 commits into from
Jan 28, 2025

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Jan 28, 2025 •
edited
Loading

Description / Motivation

Streamlined the implementation of the api/sitemap API route by replacing the use of the Streams API
Fixed the bug when api/sitemap API endpoint returned 404

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team January 28, 2025 08:57
yavorsk
yavorsk approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@illiakovalenko illiakovalenko changed the title [Next.js] Simplify sitemap.xml handling [Next.js] sitemap.xml endpoint returns 404 Jan 28, 2025
@illiakovalenko illiakovalenko merged commit aada8f2 into dev Jan 28, 2025
1 check passed
@illiakovalenko illiakovalenko deleted the bugfix/JSS-4953-follow-up branch January 28, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yavorsk yavorsk yavorsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @yavorsk