Feature/356378 #272
Merged
Feature/356378 #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,8 @@ | |||
| import { sync as delSync } from 'del'; | |||
| import { Application } from 'express'; | |||
| import { PathParams } from 'express-serve-static-core'; | |||
| import openBrowser from 'opn'; | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
There was ts-lint error, because @types/opn is not exists
| import { | ||
| convertedPlaceholderData, | ||
| rawPlaceholderData, | ||
| } from '../testData/dataConversionTestData/non-ee-data'; |
There was a problem hiding this comment.
Unused imports
| @@ -67,7 +67,7 @@ async function renderAppToResponse( | |||
| } | |||
|
|
|||
| // we are going to set our own status code if rendering fails | |||
| serverResponse.writeHead = () => {}; | |||
| serverResponse.writeHead = () => serverResponse; | |||
There was a problem hiding this comment.
ServerResponse interface is changed, writeHead requires this as return type
| @@ -21,7 +21,7 @@ export default function(command: string, args: string[], options?: SpawnSyncOpti | |||
| process.exit(1); | |||
| } | |||
|
|
|||
| if (result.status > 0) { | |||
| if (result.status && result.status > 0) { | |||
There was a problem hiding this comment.
Interface is changed, and result can be undefined
sc-dawidrutkowski
approved these changes
Oct 7, 2019
sc-dawidrutkowski
added a commit
that referenced
this pull request
Dec 3, 2019
* Added support for TypeScript when 'jss build'ing * Type-hint field value. * Update dataModels.ts * Move type hint to Field. * Type-lock return value when defaultValue provided. * Fix to copy host style attribute to its children dynamic components * changed spacing * updates for ssr * Add loader for lazy loaded components * Add some documentation * Placeholder loading component * Use ng-template instead of ng-content * Fix typo * Export SitecoreContextReactContext See #224 * WIP: simple http listener that accepts JSS view engine args, performs SSR, and returns result to caller. * Moved JSS rendering host to separate package. * SUGCON demo prep * Removed unnecessary console.log statements from htmlTemplateFactory.js * Changed `start:http-renderer` script name to `start:rendering-host` * Demo content for content block component. * Changed `sc_renderengineurl` querystring key to the CORRECT `sc_httprenderengineurl`. doh, smh. * Incorporating `defaultAppInvocationInfoResolver` into the renderingHostServer startup script. * removed static `jss` subdomain for ngrok tunnel * Fixing tests * #61 Nested component definitions via Item Link returns only IDs * Upgrade dependencies with critical and high security issues (#252) Upgrade dependencies * Upgrade cypress * downgrade dependency version * Feature/356383 (#256) Upgrade sitecore-jss-react package dependencies * remove InferProps (#259) remove InferProps * Feature/356379 (#265) * update react sample dependencies * update dependencies and fix ts errors (#266) Upgrade Vue package dependencies * #267 Error in description of one of methods of Manifest interface * Upgrade Vue sample (#269) Upgrade Vue sample * Feature/356380: Update Angular * Upgrade jss-angular and jss-angular-schematics and jss-sample-app * Feature/356378 (#272) Upgrade CLI Packages Upgrade CLI Packages * Use Object.entries instead of Object.keys (#274) Use Object.entries instead of Object.keys * mediaApi.updateImageUrl loses revision querystring (#275) mediaApi.updateImageUrl loses revision querystring * DevTools loading hidden files and crashing (#276) * Feature/356373 (#273) Node Proxy: CURL URL -IL returns 500 OK Node Proxy: CURL URL -IL returns 500 OK * change logo (#279) change logo * upgrade react-native sample (#282) upgrade react-native sample * [React-Native] Extend Image component to render svg images (#283) * add react-native-svg to sample app * update react-native package-lock * add react-native-svg to sitecore-jss-react-native * #348713Explicitly state that field names are not affected by the serialization configuration on Layout Service (#284) * #348713 Explicitly state that field names are not affected by the serialization configuration on Layout Service * #348713 Update * Extended a CD server setup instructions (#286) * React native sample app (#291) React native sample app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.