Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-manifest] Include media from Droptree and Multilist content #285

Merged
merged 2 commits into from
Jan 30, 2020

Conversation

jacobrask
Copy link
Contributor

@jacobrask jacobrask commented Oct 29, 2019

Description

This change makes sure you also consider fields of type Droptree and Multilist.

Motivation

Currently only Treelist content definitions are traversed recursively to look for media items. If you add a field of type Multilist or Droptree its media items will not be included in the JSS import.

How Has This Been Tested?

Tested locally and is a minor change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.

Currently only `Treelist` content definitions are traversed recursively to look for media items.
This change makes sure you also consider fields of type `Multilist` fields.
@jacobrask jacobrask changed the title [sitecore-jss-manifest] Include media from Multilist content [sitecore-jss-manifest] Include media from Droptree and Multilist content Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants