Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/458679 #575

Merged
merged 6 commits into from
Feb 17, 2021
+987 −18
Merged

Fix/458679 #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5a9fc1f
Fix prop-types for errorComponent (this is a Placeholder prop in the …
anastasiya29 Jan 26, 2021
cbfd1ad
Fix 'coverage' script in react package
anastasiya29 Jan 26, 2021
07a90df
Add unit tests for customError Placeholder prop
anastasiya29 Jan 26, 2021
0552860
Update release notes
anastasiya29 Feb 17, 2021
c8d209b
Update PR # in release notes
anastasiya29 Feb 17, 2021
8bae17c
Fix linting/prettier issues
anastasiya29 Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/data/routes/release-notes/en.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ title: Release Notes
* [PR #548](https://github.com/Sitecore/jss/pull/548) [sitecore-jss-dev-tools] `jss deploy` doesn't exit on success
* [PR #541](https://github.com/Sitecore/jss/pull/541) [sitecore-jss-dev-tools][sitecore-jss-cli] Replace old and security vulnerable `request` and `axios` NPM packages with latest version of `axios` (>=0.21.1)
* [PR #506](https://github.com/Sitecore/jss/pull/506) [React sample] `Cannot read property 'sitecore' of null`, when 404 and routeData is null
* [PR #575](https://github.com/Sitecore/jss/pull/575) [sitecore-jss-react] Specifying a custom error component via the Placeholder's `errorComponent` prop caused an "Invalid prop" error.

## Sitecore JSS 15.0.1

Expand Down
4 changes: 2 additions & 2 deletions packages/sitecore-jss-cli/src/process-env.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ describe('processEnv', () => {

it('should not include environment files without NODE_ENV defined', () => {
const files = [
{ name: '.env.development', value: 'FOO=foo' },
{ name: '.env.development.local', value: 'BAR=bar' }
{ name: '.env.development', value: 'FOO=foo' },
{ name: '.env.development.local', value: 'BAR=bar' },
];
testTempEnv(files, () => {
expect(process.env.FOO).to.be.undefined;
Expand Down
Loading