Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Focused Improvement] Consolidate packages #824

Merged
merged 32 commits into from
Oct 25, 2021
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
e26fab2
Add index to layout folder
CobyPear Sep 30, 2021
ae33d33
Consolidate modules
CobyPear Sep 30, 2021
91dc1c1
Move pipelines, manifest to dev-tools
CobyPear Oct 1, 2021
3f44886
replaced sitecore-jss-manifest with sitecore-jss-dev-tools in all sam…
addy-pathania Oct 1, 2021
1c4ee77
Remove some references to manifest package
CobyPear Oct 4, 2021
98c7f08
Update path in test
CobyPear Oct 4, 2021
445e71a
added tacking to the base package and replaced tracking with base pac…
addy-pathania Oct 6, 2021
421981a
added update package to dev tools
addy-pathania Oct 7, 2021
6fed8cc
added submodules to the base package
addy-pathania Oct 7, 2021
8f3a813
added submodules imports to nextjs base package index file
addy-pathania Oct 8, 2021
26448e8
added submodules to angular, vue, react base package index files
addy-pathania Oct 13, 2021
8fa1dc6
made changes asked in review comments
addy-pathania Oct 14, 2021
edf7b2b
resolved merge conflicts
addy-pathania Oct 14, 2021
ffdfda4
Merge remote-tracking branch 'origin/dev' into feature/479456
addy-pathania Oct 14, 2021
0934104
resolved merge conflicts
addy-pathania Oct 14, 2021
7adc339
updated changelog
addy-pathania Oct 14, 2021
e899f98
fixed nextjs sample build issue
addy-pathania Oct 14, 2021
da7325c
added comparison table doc
addy-pathania Oct 18, 2021
8c201cc
fixed CI failure issue
addy-pathania Oct 18, 2021
1514ba5
fixed CI failure issue for vue sample app
addy-pathania Oct 18, 2021
7baccf3
fixed failing test
addy-pathania Oct 18, 2021
9590b2d
resolved merge conflicts
addy-pathania Oct 19, 2021
083eb99
resolved merge conflicts
addy-pathania Oct 21, 2021
43a6297
added imports from submodules to all sample apps
addy-pathania Oct 22, 2021
0ce252c
added utils as submodule to base package
addy-pathania Oct 22, 2021
f5e5dda
added submodule import
addy-pathania Oct 22, 2021
1879f6a
updated upgrade-guide.md and added aliases
addy-pathania Oct 22, 2021
82de9ec
adde line endings, removed extra exports, added aliases for index file
addy-pathania Oct 25, 2021
428b78f
moved common shared files out of utils, updated upgrade-guide
addy-pathania Oct 25, 2021
8378495
removed comments, moved out shared files
addy-pathania Oct 25, 2021
e0bf24b
added editing back to utils, fixed failing tests
addy-pathania Oct 25, 2021
8129389
fixed failing test in vue base package
addy-pathania Oct 25, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { CommonFieldTypes, SitecoreIcon, Manifest } from '@sitecore-jss/sitecore-jss-manifest';
import { CommonFieldTypes, SitecoreIcon, Manifest } from '@sitecore-jss/sitecore-jss-dev-tools';

/**
* Adds the <%= name %> component to the disconnected manifest.
Expand Down
1 change: 0 additions & 1 deletion packages/sitecore-jss-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
},
"dependencies": {
"@sitecore-jss/sitecore-jss-dev-tools": "^20.0.0-canary.23",
"@sitecore-jss/sitecore-jss-manifest": "^20.0.0-canary.23",
"axios": "^0.21.1",
"chalk": "^2.4.2",
"cross-spawn": "^7.0.0",
Expand Down
3 changes: 1 addition & 2 deletions packages/sitecore-jss-cli/src/scripts/manifest.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { clean } from '@sitecore-jss/sitecore-jss-dev-tools';
import { generateToFile } from '@sitecore-jss/sitecore-jss-manifest';
import { clean, generateToFile } from '@sitecore-jss/sitecore-jss-dev-tools';
import chalk from 'chalk';
import { existsSync } from 'fs';
import path from 'path';
Expand Down
3 changes: 2 additions & 1 deletion packages/sitecore-jss-dev-tools/.nycrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"exclude": [
"**/*.d.ts",
"**/*.test.ts",
"src/testData",
"src/**/testData",
"src/pipelines/test",
"dist",
"types"
],
Expand Down
Loading