Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Focused Improvements] [Next.js] Remove locale variants from default rewrites #832

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Oct 13, 2021

…rewrites

Description / Motivation

Next.js provides way to don't specify locale for rewrites, we need to use it:
https://nextjs.org/docs/api-reference/next.config.js/rewrites#rewrites-with-i18n-support

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update (non-breaking change; modified files are limited to the /docs directory)

@vercel
Copy link

vercel bot commented Oct 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/BB68PtyQwAEfeyXmSPvdNBcBLgnE
✅ Preview: https://edge-e2e-styleguide-git-feature-487898-sitecore-jss.vercel.app

@illiakovalenko illiakovalenko changed the title [Focused Improvements 20] [Next.js] Remove locale variants from default rewrites [Focused Improvements] [Next.js] Remove locale variants from default rewrites Oct 13, 2021
@illiakovalenko illiakovalenko requested review from a team and removed request for a team October 13, 2021 10:50
@illiakovalenko illiakovalenko merged commit cea99c5 into dev Oct 13, 2021
@illiakovalenko illiakovalenko deleted the feature/487898 branch October 13, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant