-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Focused Improvements] Generate API reference docs #840
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/E999AFr4E1mBxhFZg4Z4EgfAdiEE [Deployment for db2e3f3 failed] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few suggestions. Looks good otherwise!
package.json
Outdated
@@ -37,4 +37,4 @@ | |||
"typescript": "^3.9.6" | |||
}, | |||
"dependencies": {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, missed this - can we remove this empty dependencies object?
Utilized TypeDoc to generate API reference docs for all the base packages.
With 1 Lerna script at the root package.json, we are able to generate docs for all the packages.
Description / Motivation
This would benefit our team internally, but also may be used for public docs if we want.
Testing Details
Run
npm run generate-docs
from the root of the repo.Types of changes
/docs
directory)