Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Focused Improvements] Generate API reference docs #840

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Oct 27, 2021

Utilized TypeDoc to generate API reference docs for all the base packages.
With 1 Lerna script at the root package.json, we are able to generate docs for all the packages.

Description / Motivation

This would benefit our team internally, but also may be used for public docs if we want.

Testing Details

Run npm run generate-docs from the root of the repo.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update (non-breaking change; modified files are limited to the /docs directory)

@addy-pathania addy-pathania requested a review from a team October 27, 2021 17:05
@vercel
Copy link

vercel bot commented Oct 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/E999AFr4E1mBxhFZg4Z4EgfAdiEE
✅ Preview: https://edge-e2e-styleguide-git-feature-467457-api-a2a7b0-sitecore-jss.vercel.app

[Deployment for db2e3f3 failed]

Copy link
Contributor

@CobyPear CobyPear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions. Looks good otherwise!

package.json Outdated
@@ -37,4 +37,4 @@
"typescript": "^3.9.6"
},
"dependencies": {}
Copy link
Contributor

@CobyPear CobyPear Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed this - can we remove this empty dependencies object?

@addy-pathania addy-pathania merged commit f53b9d8 into dev Oct 29, 2021
@addy-pathania addy-pathania deleted the feature/467457-api-reference-generation branch October 29, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants