[React] [Next.js] Strongly typed SitecoreContext value #841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
<SitecoreContext/>
fromsitecore-jss-react
package should have exact type forcontext
state<Layout/>
component shouldn't runrender
when it's unnecessary<Layout />
component twice. Now it's fixed and it was happening b\c we rendered array of routes, see https://github.com/Sitecore/jss/pull/841/files#diff-b6f3b4055f9147512d69014aa8a1d1df8d4c129713f504a4ca597c75e224bb49R37-R39updateSitecoreContext
should trigger update for layout. Test it using:// withSitecoreContext({ updatable: true });
// this.props.updateSitecoreContext(freshLayoutData);
BREAKING CHANGE
layoutData
instead ofcontext
any
Testing Details
Types of changes
/docs
directory)