Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NextJS] Refactor PagePropsFactory to make it extendable #857

Merged
merged 6 commits into from
Nov 19, 2021
Merged

[NextJS] Refactor PagePropsFactory to make it extendable #857

merged 6 commits into from
Nov 19, 2021

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Nov 17, 2021 •
edited
Loading

Description / Motivation

Add plugins for PagePropsFactory to enable other teams to easily extend it

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@vercel
Copy link

vercel bot commented Nov 17, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/GoomMmRQ3x919vAVA5VDfBkcxPPU
✅ Preview: https://edge-e2e-styleguide-git-feature-506964-sitecore-jss.vercel.app

@illiakovalenko illiakovalenko requested a review from a team November 17, 2021 08:33
addy-pathania
addy-pathania approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

ambrauer
ambrauer suggested changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just some suggestions.

ambrauer
ambrauer approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just one minor question on naming convention.

@illiakovalenko illiakovalenko merged commit a26065e into dev Nov 19, 2021
@illiakovalenko illiakovalenko deleted the feature/506964 branch November 19, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

@addy-pathania addy-pathania addy-pathania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illiakovalenko @ambrauer @addy-pathania