-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initializer for Vue
sample
#883
Conversation
This reverts commit 451c35d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<%- helper.getAppPrefix(appPrefix, appName)%>
-><%- helper.getAppPrefix(appPrefix, appName) %>
: missing a space between the final)
and%>
in many placesJssVueWeb-
should be replaced with the appropriate ejs token- Check the
**/styleguide/{{language}}.yml
file in the other initializers as it has changed significantly from the sample app
packages/create-sitecore-jss/src/templates/vue/data/dictionary/{{language}}.yml
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/vue/data/routes/graphql/en.yml
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/vue/data/routes/graphql/sample-1/en.yml
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/vue/sitecore/definitions/placeholders.sitecore.js
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/vue/src/temp/GraphQLFragmentTypes.json
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/vue/src/lib/layout-service-factory.js
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/vue/src/lib/dictionary-service-factory.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some issues which should be fixed, check each file:
- Remove
Web
prefix, we are not using it - Remove space before
<%-
- Check indents
...eate-sitecore-jss/src/templates/vue/sitecore/definitions/components/ContentBlock.sitecore.js
Outdated
Show resolved
Hide resolved
...core-jss/src/templates/vue/sitecore/definitions/components/GraphQL-ConnectedDemo.sitecore.js
Outdated
Show resolved
Hide resolved
...ss/src/templates/vue/sitecore/definitions/components/GraphQL-IntegratedDemo.sitecore.graphql
Outdated
Show resolved
Hide resolved
...sitecore-jss/src/templates/vue/sitecore/definitions/components/Styleguide-Layout.sitecore.js
Outdated
Show resolved
Hide resolved
...s/create-sitecore-jss/src/templates/vue/src/components/Styleguide/Styleguide-Layout-Tabs.vue
Show resolved
Hide resolved
.../create-sitecore-jss/src/templates/vue/src/components/Styleguide/Styleguide-Multilingual.vue
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/vue/src/lib/dictionary-service-factory.js
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/vue/src/lib/dictionary-service-factory.js
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/vue/src/lib/layout-service-factory.js
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/vue/data/dictionary/{{language}}.yml
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/vue/src/lib/dictionary-service-factory.js
Outdated
Show resolved
Hide resolved
@sc-addypathania Hey there! I'm starting working on a Vue template that will use config.output.libraryTarget = 'this'; // libraryTarget: 'this' is required for use with Sitecore JavaScriptViewEngine Can anyone please give some more context? 👀 Vite and other bundlers does not support I don't know if the mentioned
|
PLEASE DO NOT MERGE!!
Description / Motivation
Testing Details
Types of changes