Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initializer for Vue sample #883

Merged
merged 133 commits into from
Dec 17, 2021
Merged

Initializer for Vue sample #883

merged 133 commits into from
Dec 17, 2021

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Dec 10, 2021

PLEASE DO NOT MERGE!!

Description / Motivation

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Contributor

@CobyPear CobyPear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • <%- helper.getAppPrefix(appPrefix, appName)%> -> <%- helper.getAppPrefix(appPrefix, appName) %>: missing a space between the final ) and %> in many places
  • JssVueWeb- should be replaced with the appropriate ejs token
  • Check the **/styleguide/{{language}}.yml file in the other initializers as it has changed significantly from the sample app

Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues which should be fixed, check each file:

  1. Remove Web prefix, we are not using it
  2. Remove space before <%-
  3. Check indents

@CobyPear CobyPear merged commit a000ed8 into dev Dec 17, 2021
@CobyPear CobyPear deleted the feature/504957-vue-initializer branch December 17, 2021 20:43
@unrevised6419
Copy link
Contributor

unrevised6419 commented Jul 18, 2022

@sc-addypathania Hey there!

I'm starting working on a Vue template that will use vite instead of vue-cli
Looking in current template I saw in server/server.vue.config.js this line

config.output.libraryTarget = 'this'; // libraryTarget: 'this' is required for use with Sitecore JavaScriptViewEngine

Can anyone please give some more context? 👀

Vite and other bundlers does not support this as a libraryTarget/format https://www.rollupjs.org/guide/en/#outputformat
It seems this is only a Webpack feature https://webpack.js.org/configuration/output/#type-this

I don't know if the mentioned JavaScriptViewEngine is this one https://github.com/pauldotknopf/JavaScriptViewEngine
But from examples it seems you can have an usual module.exports 🤔

exportedFunctionName String
Specifies the CommonJS export to be invoked.

https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.nodeservices.inodeservices.invokeexportasync?view=aspnetcore-3.1#microsoft-aspnetcore-nodeservices-inodeservices-invokeexportasync-1(system-string-system-string-system-object())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants