-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get SQL databases working again #7653
base: dev/feature
Are you sure you want to change the base?
Get SQL databases working again #7653
Conversation
could you push the SkriptLang branch to your fork, then do the work there? once things are ready you can open a PR from that branch to SkriptLang |
This comment was marked as resolved.
This comment was marked as resolved.
I guess I'm confused why we'd merge into enhancement/sql instead of having your work on your fork's branch and then you can open a PR from the fork branch to dev/feature |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See existing change requests from pickle at previous pr, too: #5646 (review)
### VS Code ### | ||
.vscode/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't be in this pr
src/main/java/org/skriptlang/skript/variables/storage/H2Storage.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/variables/storage/MySQLStorage.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/variables/storage/SQLiteStorage.java
Outdated
Show resolved
Hide resolved
src/test/java/org/skriptlang/skript/variables/storage/H2StorageTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/skriptlang/skript/variables/storage/SQLiteStorageTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: sovdee <[email protected]>
Co-authored-by: sovdee <[email protected]>
Description
commit changes
option which is essentially how Skript used to operate. Changed the JDBC standard to auto commit after every edit (Make the 5-min variable saving period configurable #2007). This is standard and better for performance. Skript didn't for some reason. I speculate it was to allow MySQL to sync with other servers, so either way it's an option now.Perks
TODO
MERGE INTO
instead ofINSERT
.Optional
Notes:
Testing and using this jar
To test this experimental feature out, go to the "checks" tab and then click a Java version on the side and then click the nightly artifacts to get a built jar of the latest commit.
Target Minecraft Versions: any
Requirements: none
Related Issues: #1168, #2007, #1478 and #3948