Skip to content
This repository was archived by the owner on Apr 5, 2024. It is now read-only.

feat(main): add talisman pre-commit hook #86

Merged
merged 2 commits into from
Jul 27, 2022
Merged

feat(main): add talisman pre-commit hook #86

merged 2 commits into from
Jul 27, 2022

Conversation

revolunet
Copy link
Member

For the main branch

@revolunet revolunet marked this pull request as ready for review July 26, 2022 17:45
@revolunet revolunet requested a review from a team July 26, 2022 17:46
matmut7
matmut7 reviewed Jul 27, 2022
View reviewed changes
maxgfr
maxgfr approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@maxgfr maxgfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top talisman

On pourrait l'ajouter directement dans le lint-staged.config.js afin d'avoir un selector qui run que sur les nouveaux files commit pour gagner en performance

@revolunet revolunet changed the title feat(main): add talisman feat(main): add talisman pre-commit hook Jul 27, 2022
@revolunet
Copy link
Member Author

@maxgfr ca prend bien que le "stage" avec le pre-commit hook

@maxgfr
Copy link
Member

maxgfr commented Jul 27, 2022

@revolunet oui en effet, my bad, le lint-staged.config.js est juste là pour dire : si t'es un ts, tu fais ça, mais si t'es du tsx tu fais cela

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@revolunet revolunet merged commit 8465982 into main Jul 27, 2022
@revolunet revolunet deleted the main-talisman branch October 28, 2022 10:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxgfr maxgfr maxgfr approved these changes

@matmut7 matmut7 matmut7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@revolunet @maxgfr @matmut7