fix API8 datafixers #2622
Closed
fix API8 datafixers #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i509VCB
reviewed
May 24, 2020
| final Type<?> trackedType = spongeDataType.findFieldType(name); | ||
| final OpticFinder<?> trackedFinder = DSL.fieldFinder(name, trackedType); | ||
|
|
||
| return this.fixTypeEverywhereTyped("Entity" + name + "UserFix", this.getInputSchema().getType(TypeReferences.ENTITY), |
There was a problem hiding this comment.
This is where things go down hill...
So TypeReferences.ENTITY does not exist on any schemas of Sponge's datafixer.
This means this will fail to fix, hard fail. The solution to this is the include minecraft's own schema into your datafixer, at a lower version than sponge's current schema version so the type reference exists.
Even then, there is a whole extra can of beans with the entity type reference, but that is closer to how modded entities are handled during registration.
There was a problem hiding this comment.
However that itself can be a mess, and I need to sleep. So I can clarify tomorrow.
| @@ -35,12 +38,13 @@ | |||
| import java.util.Map; | |||
| import java.util.UUID; | |||
|
|
|||
| public class PlayerRespawnData implements IFixableData { | |||
| // TODO this is actually doing nothing? | |||
| public class PlayerRespawnData extends DataFix { | |||
|
|
|||
There was a problem hiding this comment.
You'd probably want to call this PlayerRespawnDataFix
gabizou
added a commit
that referenced
this pull request
May 31, 2020
Signed-off-by: Gabriel Harris-Rouquette <[email protected]>
|
Merged into api-8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after #2620