Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new trade offer logic #3040

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Implement new trade offer logic #3040

merged 1 commit into from
Jul 15, 2020

Conversation

i509VCB
Copy link
Contributor

@i509VCB i509VCB commented Jul 4, 2020

And some whitespace for the builder.

gabizou
gabizou approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@gabizou gabizou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Null check aside, I'd be willing to make the second buying item as a null setter as well, but nitpicks are nitpicks.

@Zidane Zidane merged commit e37e145 into SpongePowered:api-8 Jul 15, 2020
@i509VCB i509VCB deleted the tradeoffer2 branch January 30, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabizou gabizou gabizou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@i509VCB @gabizou @Zidane