Add more Sponge commands: #3078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dualspiral
commented
Jul 20, 2020
|
|
||
| public final class SpongeCommand { | ||
| public class SpongeCommand { |
There was a problem hiding this comment.
@Zidane I know you like final things, but this is intended to be overriden by SpongeForge to add any additional commands it sees fit, like /sponge mods, and injected via Guice (so it'll need an explicit binding on SF).
dualspiral
force-pushed
the
api8/sponge-commands
branch
from
546065f to
888c3de
Compare
* /sponge which * /sponge version * /sponge plugin <plugin> Also ensure suggestions that are returned get filtered by startsWith Also also: generics are a bit better now
dualspiral
force-pushed
the
api8/sponge-commands
branch
from
888c3de to
eeebfb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ensure suggestions that are returned get filtered by startsWith
Also also: generics are a bit better now
Requires SpongePowered/SpongeAPI#2181