Replace RunAroundLikeCrazyGoalMixin::tick overwrite with injects #4151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be easy to change to just use redirects instead and avoid the overwrite? |
|
Yea the reason i was even working on this is because I'm rewriting it like that since the overwrite is conflicting with Architechtury API on fabric. I can update this PR with the rewritten version once I finish that after dinner if wanted. |
|
We would like to get rid of overwrites as much as possible. |
gabizou
reviewed
Nov 14, 2024
| @@ -42,6 +43,8 @@ | |||
| @Mixin(Goal.class) | |||
| public abstract class GoalMixin implements GoalBridge { | |||
|
|
|||
| @Shadow protected abstract int adjustedTickDelay(int $$0); | |||
There was a problem hiding this comment.
I'd recommend explicitly naming the method shadowed shadow$adjustedTickDelay so it's clearer
nelind3
changed the title
|
There we go now it's replacing the overwrites with injects instead |
aromaa
approved these changes
Nov 14, 2024
...va/org/spongepowered/common/mixin/core/world/entity/ai/goal/RunAroundLikeCrazyGoalMixin.java
Outdated
Show resolved
Hide resolved
...va/org/spongepowered/common/mixin/core/world/entity/ai/goal/RunAroundLikeCrazyGoalMixin.java
Outdated
Show resolved
Hide resolved
|
There you go :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated another outdated overwrite that I noticed while working on Loofah.