Fix issue in paramiko test script #5325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identified by manual pylint run (script not normally covered by pylint). Code was moved from st2common/bin/paramiko_ssh_evenlets_tester.py to st2common/st2common/ssh/parallel_ssh.py in 081d2ef (2015-07-31) Then it moved to st2actions/st2actions/runners/ssh/parallel_ssh.py in 82c2508 (2015-08-06) This change did not, however, update the imports in st2common/bin/paramiko_ssh_evenlets_tester.py Then it moved to contrib/runners/ssh/parallel_ssh.py in 40d9270 (2016-07-21) Then it moved to st2common/st2common/runners/parallel_ssh.py in 718a029 (2016-09-20) So, this has been broken since 2015, and no one has complained. But, maybe an eventlet tester will come in handy, so I'll just fix the import and be on my way. What a satisfying end to a twisty git spelunking session.
pull-request-size
bot
added
the
size/XS
winem
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified by manual pylint run (script not normally covered by pylint).
Code was moved from
st2common/bin/paramiko_ssh_evenlets_tester.pytost2common/st2common/ssh/parallel_ssh.pyin 081d2ef (2015-07-31)Then it moved to
st2actions/st2actions/runners/ssh/parallel_ssh.pyin 82c2508 (2015-08-06)This change did not, however, update the imports in
st2common/bin/paramiko_ssh_evenlets_tester.pyThen it moved to
contrib/runners/ssh/parallel_ssh.pyin 40d9270 (2016-07-21)Then it moved to
st2common/st2common/runners/parallel_ssh.pyin 718a029 (2016-09-20)So, this has been broken since 2015, and no one has complained. But, maybe an eventlet tester will come in handy, so I'll just fix the import and be on my way.
What a satisfying end to a twisty git spelunking session.