Tests fail to start due to missing module

[twongCMU]

Hello. I cloned the repo and tried to run the tests:

python3 setup.py test

This fails with
ImportError while loading conftest '/tmp/stingray-test-hc6wpz0t/lib/python3.5/site-packages/stingray/conftest.py'. stingray/conftest.py:5: in <module> from astropy.tests.pytest_plugins import * E ImportError: No module named 'astropy.tests.pytest_plugins'

I believe this is related to this issue which indicates that the tests have been removed from the astropy package. This pull request describes the move from conftest.py to setup.py

If I edit stingray/conftest.py and comment out the line
from astropy.tests.pytest_plugins import *
then the tests run and pass

Versions:
platform linux -- Python 3.5.2, pytest-4.6.3, py-1.8.0, pluggy-0.12.0

Running tests with Astropy version 3.2.1.
Running tests in stingray docs.

Date: 2019-06-29T13:05:33

Platform: Linux-4.4.0-150-generic-x86_64-with-Ubuntu-16.04-xenial

Executable: /usr/bin/python3

Full Python Version:
3.5.2 (default, Nov 12 2018, 13:43:14)
[GCC 5.4.0 20160609]

encodings: sys: utf-8, locale: UTF-8, filesystem: utf-8
byteorder: little
float info: dig: 15, mant_dig: 15

Numpy: 1.16.4
Scipy: 1.3.0
Matplotlib: 3.0.3
h5py: 2.9.0
Pandas: 0.24.2
astropy_helpers: 3.2.1
Using Astropy options: remote_data: none.

rootdir: /tmp/stingray-test-cpm9w50e/lib/python3.5/site-packages, inifile: setup.cfg
plugins: doctestplus-0.3.0, arraydiff-0.3, remotedata-0.3.1, openfiles-0.3.2

[twongCMU]

This also happens on Ubuntu 18.04.2 LTS

platform linux -- Python 3.6.7, pytest-4.6.3, py-1.8.0, pluggy-0.12.0

Running tests with Astropy version 3.2.1.
Running tests in stingray docs.

Date: 2019-06-29T13:05:31

Platform: Linux-4.15.0-51-generic-x86_64-with-Ubuntu-18.04-bionic

Executable: /usr/bin/python3

Full Python Version:
3.6.7 (default, Oct 22 2018, 11:32:17)
[GCC 8.2.0]

encodings: sys: utf-8, locale: UTF-8, filesystem: utf-8
byteorder: little
float info: dig: 15, mant_dig: 15

Numpy: 1.16.4
Scipy: 1.3.0
Matplotlib: 3.1.0
h5py: 2.9.0
Pandas: 0.24.2
astropy_helpers: 3.2.1
Using Astropy options: remote_data: none.

rootdir: /tmp/stingray-test-gpgpnhb9/lib/python3.6/site-packages, inifile: setup.cfg
plugins: doctestplus-0.3.0, remotedata-0.3.1, arraydiff-0.3, openfiles-0.3.2

[twongCMU]

I submitted a pull request with this fix so this issue can be closed if that is accepted

[matteobachetti]

Hi @twongCMU , thanks a lot! I took a look at the fixes, I'll try to review properly tonight or tomorrow morning at the latest (Bad connection during the weekend).

[matteobachetti]

Resolved by @twongCMU's PR. Thanks!