-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1. Have tests inspect an exception's e.value instead of just t… #417
Conversation
Fixed release badge missing line Fixed identifier Will the dashes fix things? Added JOSS back in Removed the old badges from readme
…he exception. pytest 5.0.0 no longer displays the custom text with str(e)
It looks like the CI tests fail due to #416 and not my changes |
Bah. I fixed two issues in the forked branch, but when I submitted the pull request the links now refer to issues in this stingray repo's issue tracker, which is wrong. Anyway, here are the two issues I fixed: |
Hi @twongCMU, thanks a lot! I'm not sure that the complete removal of An example of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…3.2.1 Update astropy-helpers to v3.2.1
…he exception. pytest 5.0.0 no longer displays the custom text with str(e)
Hello @twongCMU! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Yes, I agree that it is better to keep conftest.py |
…he exception. pytest 5.0.0 no longer displays the custom text with str(e)