Ruby 3.2.0 compatibility
#170
Conversation
No, likely safe to start dropping some of the older ones. Once an older version is dropped then it would be safe to remove the guard around any of the
Ahh.. yes. I'll need to fix that, thanks. |
|
I see that cookie rederer is being replaced so I've removed older checks for puppetter versions(with assumption that "supported" versions are roughly those in updated GH actions). |
|
yes, although there is another issue with a change to how newer versions of rspec deal with hash vs keyword arguments I still need to fix up 😬 |
|
The rspec-mocks hash vs keyword arguments issue with Ruby 3.2 is resolved in 3.12.2, so you shouldn't have to change anything in your tests so long as rspec has been updated |
|
I've already fixed tests regarding that. |
Sorry, I didn't mean to chime in and detract from the work happening here. I only wanted to point out the issue described in rspec/rspec-mocks#1513 was resolved in rspec/rspec-mocks#1514, and as far as I know tests shouldn't need to be fixed as long as On another note, would it be possible to relax the I'm currently blocked from updating Ruby version by this requirement. I understand not wanting to support older versions of Ruby and only wanting to explicitly support certain versions at a given time, but this feels overly restrictive. It also adds some pressure to maintainers when new versions are released that could be avoided. How do you feel about adjusting the requirement to something like this instead? spec.required_ruby_version = ">= 2.7.0"Thanks to everyone that works on this gem, your work is appreciated ❤️ |
That's not the case. The tests run against the latest versions of
Except then you have the situation where someone upgrades to the latest version.. gem installs fine, thus assumes everything must be fine. Except what if it isn't. If you have unbounded version checks you leave yourself very open to the unexpected/breakages/bugs/crashes/etc. It's why the project has the version matrix testing the code in CI. Short term option.. fork the project, update the required version to your liking, use the fork in your project until grover + 3.2.x has been properly tested. 😄 But of course that goes with the caveat that it hasn't been properly tested. |
|
We REALLY need Ruby 3.2 support. |
|
FYI @Yobilat I've released Ruby 3.2.x grover support in v1.1.3 Thank you for your efforts in getting this through, although note I stripped parts of your PR out into separate PRs. It was trying to do a little too much all in one go, and I wasn't a fan of your matrix re-org.. it would have meant a full 3 (node versions) X 6 (puppeteer versions) + 3 static builds per run. |
|
Great work! Thanks @abrom |
Changes:
Questions:
puppeteer_version_on_or_after?)?