Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(query-core): add test case for ensureQueryFn with skipToken #8725

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

test(query-core): add test case for ensureQueryFn with skipToken #8725

wants to merge 4 commits into from
+36 −7

Conversation

manudeli
Copy link
Contributor

@manudeli manudeli commented Mar 1, 2025

No description provided.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 1, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit b5884bb.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 4m 59s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 56s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-01 16:31:48 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Mar 1, 2025 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8725

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8725

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8725

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8725

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8725

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8725

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8725

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8725

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8725

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8725

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8725

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8725

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8725

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8725

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8725

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8725

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8725

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8725

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8725

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8725

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8725

commit: b5884bb

@codecov Codecov
Copy link

codecov bot commented Mar 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.17%. Comparing base (2bf7ec6) to head (b5884bb).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8725       +/-   ##
===========================================
+ Coverage   46.31%   63.17%   +16.86%     
===========================================
  Files         199      135       -64     
  Lines        7552     4856     -2696     
  Branches     1731     1369      -362     
===========================================
- Hits         3498     3068      -430     
+ Misses       3674     1543     -2131     
+ Partials      380      245      -135
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 88.65% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 94.26% <100.00%> (+0.18%) ⬆️
@tanstack/query-devtools 4.78% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.09% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.20% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 87.33% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.01% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo
Copy link
Collaborator

TkDodo commented Mar 1, 2025

I don’t think we should allow running an imperative function with a skipToken. There’s no enabled:boolean for those, either.

A better fix would be to get a type error if this is attempted.

@manudeli manudeli force-pushed the query-core/test/ensureQueryFn-skipToken branch from 9dd6ce2 to 274378a Compare March 1, 2025 11:39
@manudeli
Copy link
Contributor Author

manudeli commented Mar 1, 2025

I don’t think we should allow running an imperative function with a skipToken. There’s no enabled:boolean for those, either.

A better fix would be to get a type error if this is attempted.

@TkDodo I reflect your review in 274378a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: query-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manudeli @TkDodo