Implement DTCANCoder.java
#16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmarchetti
reviewed
Apr 13, 2023
| } | ||
|
|
||
| public DTCANCoder(int canID, String canBus) { | ||
| internal = new CANCoder(canID, canBus); |
There was a problem hiding this comment.
Only one of the constructors calls setPositionToAbsolute, is that intentional?
There was a problem hiding this comment.
Also I recall that the cancoder can be configured to return values from -180 to 180, or 0 to 360, and it seems like we might want different zero positions depending on the application.
There was a problem hiding this comment.
Fixed the constructor, and that is a good addition
mmarchetti
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.