Cleanup DTLog, implement log levels #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MathNerd28
commented
Oct 12, 2023
MathNerd28
commented
- Add version suffix in DTLibInfo
- Remove duplicate mode logging
- Use tryFlush() instead of flush()
- Add constant LOG_PATH_SEPARATOR
- Use RobotController.getTeamNumber() instead of custom implementation
- Change unknown team number to 0
- General cleanup, suppress useless warnings
MathNerd28
requested review from
mmarchetti,
BrandonDudek,
ptavolette and
err1482
MathNerd28
changed the title
|
Implement log levels for variables. They filter variables based on their immediate parent's log level, allowing components to be selectively logged based on the current level. Levels for variables are not denoted in the log output. Also, properly implement log levels for messages. These are denoted in the log, under identifiers 0x0008 through 0x000B. |
|
Properly log exceptions where applicable (not during startup, DEBUG level when explicitly caught, etc.) |
|
This PR is ready for review |
mmarchetti
reviewed
Oct 14, 2023
| writeInt(checksum); | ||
|
|
There was a problem hiding this comment.
You might consider something like CRC32 for the checksum: https://docs.oracle.com/javase/8/docs/api/java/util/zip/CRC32.html
mmarchetti
reviewed
Oct 14, 2023
mmarchetti
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.