Fix #242: fix ruff issues
#243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinich1
approved these changes
Jan 14, 2025
|
@thierry-martinez could you perhaps fix the |
|
In 3d37711, I set the ruff version to 0.9.2 (current last version). |
EarlMilktea
reviewed
Jan 25, 2025
|
@thierry-martinez Could you update |
Spotted by EarlMikltea: TeamGraphix#243 (comment). The rule was renamed in ruff 0.8: astral-sh/ruff#9573
Thanks for having spotted this! Fix in 263509b. |
See discussion here: TeamGraphix#243 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies
ruff check --fixand changes a percent format into an f-string to make graphix code base passruff checkagain.