Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewPipe v0.21.10 broke 'Search History' functionality #7133

Closed
4 tasks done
astatine opened this issue Sep 21, 2021 · 6 comments · Fixed by #7491
Closed
4 tasks done

NewPipe v0.21.10 broke 'Search History' functionality #7133

astatine opened this issue Sep 21, 2021 · 6 comments · Fixed by #7491
Labels
bug Issue is related to a bug

Comments

@astatine
Copy link

Checklist

Steps to reproduce the bug

  1. Press the search icon
  2. Search YouTube for anything, say 'Taylor Swift' and click any of the search suggestions

Actual behavior

The search itself works, but my searched text 'Taylor Swift' doesn't get added to my search history

Expected behavior

The searched text 'Taylor Swift' should get added to my search history

Device info

  • Android version/Custom ROM version: MIUI v12.0.3 running Android 10 32-bit
  • Device model: Xiaomi Redmi 7A (2GB RAM, 32GB storage, 17GB free space)
@astatine astatine added the bug Issue is related to a bug label Sep 21, 2021
@jstetten
Copy link

Even before this release, roughly ⅓ of my newest search terms have sporadically failed to be recorded in my search history. I'm not certain when the problem first appeared, but it's been happening for several if not many weeks. (I use the built-in app GitHub updates).

@efb4f5ff-1298-471a-8973-3d47447115dc

Im not sure if it belongs here but if the search history is being displayed, it is now displayed in a weird order since the last update.

@jstetten
Copy link

Yes!

I was going to create a separate issue about this exact problem because it is a much more serious violation of data consistency and it was introduced solely in v0.21.10.

Is it actual timestamp corruptions in the database from the upgrade process, or some sort of sorting error in the app UI layer? I don't know but it is the first showstopper bug I've ever had with this wonderful app, making this version unusable for me.

@litetex
Copy link
Member

litetex commented Sep 28, 2021

When I reset the app / install it into a fresh emulator I get the same problem.
However searching once fixes the problem.
Probably some kind of invalid state at startup.

@Flam3z
Copy link

Flam3z commented Oct 1, 2021

Wanted to chime in as well stating that I also have a similar issue, seems to be a very low chance that my searched ever get saved at all even after trying different way to get it saved such as, pressing into a suggested search, searching then hitting enter.

@DarkKnight1444
Copy link

The search history does appear but it doesn't appear in chronological order. I search something, say xyz, then xyz should appear at the top of search history but instead it appears somewhere in between other older searches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants