Fix order of local search results #7491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stypox
force-pushed
the
fix-search-order
branch
from
284f616 to
b9fb39a
Compare
litetex
reviewed
Dec 4, 2021
app/src/main/java/org/schabi/newpipe/database/history/dao/SearchHistoryDAO.java
Outdated
Show resolved
Hide resolved
litetex
reviewed
Dec 4, 2021
app/src/main/java/org/schabi/newpipe/fragments/list/search/SearchFragment.java
Outdated
Show resolved
Hide resolved
XiangRongLin
reviewed
Dec 6, 2021
app/src/main/java/org/schabi/newpipe/local/history/HistoryRecordManager.java
Show resolved
Hide resolved
Stypox
force-pushed
the
fix-search-order
branch
from
b9fb39a to
2b93e64
Compare
litetex
previously approved these changes
Dec 8, 2021
XiangRongLin
reviewed
Dec 8, 2021
app/src/androidTest/java/org/schabi/newpipe/testUtil/DatabaseMocker.kt
Outdated
Show resolved
Hide resolved
Stypox
force-pushed
the
fix-search-order
branch
from
2b93e64 to
2963cd5
Compare
XiangRongLin
approved these changes
Dec 12, 2021
Comment on lines
+44
to
+46
| // For some reason the Flowable returned by getAll() never completes, so we can't assert | ||
| // that the number of Lists it returns is exactly 1, we can only check if the first List is | ||
| // correct. Why on earth has a Flowable been used instead of a Single for getAll()?!? |
5 tasks
1 task
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Results from the local database were being fetched from the database in the correct order, but then the
DISTINCTpart of the query was not done by SQL but by Java using aSet, which then caused all items to be ordered alphabetically and not by creation date. This PR fixes this by having the related queries just return a list of strings that are already the correct ones and in the correct order. I just addedDISTINCTto the queries.Fixes the following issue(s)
Fixes #7133
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence