Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play Button does not hide if playback is resumed externally (keyboard or bluetooth earpiece) #7340

Closed
4 tasks done
ktprograms opened this issue Nov 1, 2021 · 1 comment · Fixed by #7341
Closed
4 tasks done
Labels
duplicate Issue or discussion is a duplicate of an existing issue or discussion template ignored The user didn't follow the template/instructions (or removed them)

Comments

@ktprograms
Copy link
Contributor

Checklist

Steps to reproduce the bug

  1. Start playing a video
  2. Pause the video (doesn't matter how it's done, can be with the pause button or externally)
  3. Use either a keyboard's space button or a bluetooth earpiece to resume the playback.

I think the problem is that hideControls isn't called when using the media keys

Actual behavior

The play button stays visible.

Expected behavior

The play button should hide, like when you tap the button manually.

Device info

Not applicable, happens on all the devices I've tested.

@ktprograms ktprograms added the bug Issue is related to a bug label Nov 1, 2021
@opusforlife2 opusforlife2 added the player Issues related to any player (main, popup and background) label Nov 1, 2021
@triallax
Copy link
Contributor

triallax commented Nov 3, 2021

Duplicate of #3403. I edited your PR's body to reference it.

@triallax triallax closed this as completed Nov 3, 2021
@triallax triallax added the duplicate Issue or discussion is a duplicate of an existing issue or discussion label Nov 3, 2021
@AudricV AudricV added template ignored The user didn't follow the template/instructions (or removed them) and removed bug Issue is related to a bug player Issues related to any player (main, popup and background) labels Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issue or discussion is a duplicate of an existing issue or discussion template ignored The user didn't follow the template/instructions (or removed them)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants