-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix player controls not hiding if resumed from media button #7341
Fix player controls not hiding if resumed from media button #7341
Conversation
@litetex Can you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, this bug has been bugging me for months (almost always use BT headphones with the tablet slightly out of reach).
Just want this fix in sooner than later, and I've tested the custom APK in Checks and it works as expected. 👍
app/src/main/java/org/schabi/newpipe/player/playback/PlayerMediaSession.java
Show resolved
Hide resolved
@litetex what do you think about my suggestions? If they look good, commit them and then merge and squash (after 0.22.1) |
@Stypox |
@litetex What do you mean? Should I commit/squash the suggestions? |
When not in fullscreen SPACE should be not handled by the player, and hence result in a scroll down
Kudos, SonarCloud Quality Gate passed! |
Hey guys, is this meant to be fixed now in release 23? Because it's definitely not. Resuming from the BT headset play/pause button still keeps the UI on screen forever. |
It was meant to be fixed, yes, but the latest ExoPlayer update broke the original fix, and a new fix has been provided in the PR linked above: #8315. |
What is it?
Description of the changes in your PR
hideControls(0, 0)
to the Space key pressed and thePlayerMediaSession
play
method (only if the player is currently playing)Before/After Screenshots/Screen Record
Before.mp4
After.mp4
Fixes the following issue(s)
Fixes Play Button does not hide if playback is resumed externally (keyboard or bluetooth earpiece) #7340(I made that issue then only looked at how to fix it)APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence