comments support

[yausername]

The code is crappy and needs lot of work.

[TobiGr]

@yausername Please rebase your changes in this and in the extractor repo so we can start to test and review.

[theScrabi]

I will start to reviw this soon.

[yausername]

requires TeamNewPipe/NewPipeExtractor#101

[theScrabi]

@yausername there are several changes that have to be made in the backend first: https://github.com/TeamNewPipe/NewPipeExtractor/pull/101/files

[TobiGr]

Hey @yausername,
I quickly tested your changes and what I saw looks really good 👍 Unfortunately, I do not have time for code reviews at the moment.

• There should be a content setting which allows the user to disable comments.
• Loading the video detail view seems to be way slower than usual. Do you fetch the comments asynchronously? I am not aware of any code you did here or in the extractor, so this is something @theScrabi might discuss with you further.
• I am not sure if this is a good idea, but maybe we should make it easier to switch between the "comments" and "next video" tabs. Do you guys think we should detect horizontal swipes?

In case we are able to fetch nested comments one day, we need to discuss a proper design for that.

[yausername]

Hi @TobiGr,
Thanks for the feedback.

• Yes there should be a setting to disable comments. I'll add it.
• Yes I am fetching comments asynchronously. Did you check on the latest code 803b8ea because the video detail seems to load just as quick for me.
• I have no experience in android. Maybe we can try this https://developer.android.com/reference/android/support/v4/view/ViewPager

[yausername]

@TobiGr I have made some change for

• adding content setting to disable comments.
• switch tabs with horizontal swipe - viewpager
• Changed from parallaxscrollview to coordinate layout.

Please test and give feedback if/when you have time

Thanks

[TobiGr]

@yausername Thanks for taking a look at my suggestions. I am sorry for the late response, but I rarely find spare time for larger PRs at the moment.

Yes I am fetching comments asynchronously. Did you check on the latest code 803b8ea because the video detail seems to load just as quick for me.

Maybe it was my wifi. It is kinda unstable and slow...

I really like your changes so far. Comment support will be an significant improvement for NewPipe 👍 There are still some things to do from UI and UX side, but I guess someone will find time to take a look at the code soon.

Below you can see two screenshots. The left one was taken with NewPipe 0.14.2 and the right one at your latest commit. As you can see (I hope so, the divider is hard to see at my screenshots), we separate the "next video" from the other recommended videos. It might be good if you keep the next video and separate it from the others.

When comments are disabled, there is no "next video" heading. But to be honest, I am not sure if we need one. @theScrabi What do you think?
We might also discuss what to do with the black divider which usually divides the tab headings and their content. In my opinion, we can keep it, but there should be more horizontal space around it.

[yausername]

@TobiGr Thanks for taking time for the feedback. I will look into your suggestions.

[theScrabi]

@yausername
There is another thing. I don't like the huge tab 'commends' and 'downloads' as they take away a loot of screenspace.
I'd rather like to have something like floating indicator dots:

[avently]

@yausername thanks, man! This is what I wanted long time

[theScrabi]

@TobiGr you have ben granded write access for frontend as well as backend, please feel free to review and merge PRs (especially the smaller ones). You would help me a lot, and help to make releases go faster :)

[avently]

Finally.
@TobiGr, as your first task, please, merge this PR:) with your help this project will get new life

[TobiGr]

@theScrabi Thanks, I'll take a look at the extractor once I finished my exam on monday.

[theScrabi]

Merged the extractor though :). I had time today.

[theScrabi]

Code does not look bad to me. However could someone else please give another final review?

[theScrabi]

Please also think about QA.
Therefore here is a version build and signed with my keys:
NewPipe-v0.15.1_with_commends.apk.zip

[theScrabi]

Padding in settings should be removed.

[justanidea]

This works well on my device. Anyways, would be possible to set the default pannel on the next videos? I use it more often than comments, and i think its going to be really annoying to swipe at each video
A big TY anyways

[avently]

Absolutely agree with panels reordering

[yausername]

Padding in settings should be removed.

Done

[theScrabi]

@justanidea maybe the last state of the panel could be saved.
You guys are welcome to help :)

[theScrabi]

F*** it, it worx.

[theScrabi]

@yausername thanks a lot, great work 👍

[cryptono]

@theScrabi, when is the next apk release going to be published? Can't wait for the comment support! 👍

[theScrabi]

Lets say next thing i do in newpipe is another release ;)

[theScrabi]

@yausername I encountered the first bug, would you please take a look at it?

[yausername]

@yausername I encountered the first bug, would you please take a look at it?

Sure, I'll take a look.

[skylarmt]

I just want to say thank you for the comments support, it's always been annoying when a video says there's more info in the comments. However, it's funny how at the same time NewPipe gets comments, YouTube starts shutting down comments on an entire category of videos :)

[Mhowser]

Yeah, being able to read the comments is a huge plus. Next thing we should have is comment replies.

…

On Sun, Mar 3, 2019, 11:06 AM Skylar Ittner ***@***.***> wrote: I just want to say thank you for the comments support, it's always been annoying when a video says there's more info in the comments. However, it's funny how at the same time NewPipe gets comments, YouTube starts shutting down comments on an entire category of videos :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1650 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AXEx9IicL7yeHCSX--8fASuKVNLJifE4ks5vTB0xgaJpZM4WXFnw> .