Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request template reworked #4317

Merged
merged 5 commits into from
Oct 14, 2020
Merged

Conversation

comradekingu
Copy link
Contributor

@comradekingu comradekingu commented Sep 25, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • record videos
  • create clones
  • take over the world

Fixes the following issue(s)

Relies on the following changes

Testing apk

debug.zip

Agreement

Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TobiGr TobiGr added the meta Related to the project but not strictly to code label Sep 25, 2020
Copy link
Collaborator

@opusforlife2 opusforlife2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small grammar stuff.

Co-authored-by: opusforlife2 <[email protected]>
@opusforlife2
Copy link
Collaborator

I like the term 'due diligence'. We should have this section in the bug report template as well. A list of checkboxes asking if the user is on the latest version, has checked for duplicates, etc.

Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@TobiGr TobiGr merged commit e110457 into TeamNewPipe:dev Oct 14, 2020
This was referenced Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the project but not strictly to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants