Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small adjustments to notification settings layout #4340

Merged
merged 2 commits into from
Sep 29, 2020

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Sep 28, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

BeforeAfterDescription
This PR contains improvements and adjustments of the notification settings layout for devices with small screens. In particular I removed line number restrictions from text views.

Testing apk

I thought I had tried with a small screen while testing #3178, but apparently I didn't, by looking at this user screenshot.
app-debug.zip

Agreement

@TobiGr TobiGr added the GUI Issue is related to the graphical user interface label Sep 28, 2020
@Stypox Stypox added this to the 0.20.0 milestone Sep 29, 2020
@Stypox
Copy link
Member Author

Stypox commented Sep 29, 2020

@TobiGr this should be merged in 0.20.0, otherwise the settings menu would look strange

@TobiGr TobiGr force-pushed the notification-settings-fix branch from 969ede4 to 6ffbb7b Compare September 29, 2020 19:47
@TobiGr TobiGr merged commit ed51c8b into TeamNewPipe:dev Sep 29, 2020
@TobiGr TobiGr mentioned this pull request Oct 1, 2020
@Stypox Stypox deleted the notification-settings-fix branch August 4, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants