Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate AboutActivity to ViewPager2 #4553

Merged
merged 1 commit into from
Oct 18, 2020
Merged

Migrate AboutActivity to ViewPager2 #4553

merged 1 commit into from
Oct 18, 2020

Conversation

TacoTheDank
Copy link
Member

@TacoTheDank TacoTheDank commented Oct 17, 2020

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Migrates AboutActivity to viewpager2, the first (and hands-down the easiest) of the viewpager trio (the others being MainFragment and VideoDetailFragment (oh god no), respectively). Whoever dares migrate the next two, may the odds be ever in your favor.

Fixes the following issue(s)

  • Nothing, and if we're lucky, doesn't create any either.

APK testing

app-debug.zip

Due diligence

@opusforlife2
Copy link
Collaborator

Whoever dares migrate the next two, may the odds be ever in your favor.

xD

@TacoTheDank
Copy link
Member Author

If you want #3697 to be done first, this could be merged to a separate branch for viewpager2 and saved until after viewbinding is done (though at the rate it seems to be going, might not be until 2023).

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving the code base! This looks good and works correctly: I tested playing with tabs and licenses on emulated Android 4.4 and Android 10, and on device Android 7.0.

If you want #3697 to be done first, this could be merged to a separate branch for viewpager2 and saved until after viewbinding is done

No, I tested this now and it works now, so I'd merge it right away. @wb9688 can I?

(though at the rate it seems to be going, might not be until 2023).

Yeah, that's also something ;-)

@Stypox Stypox self-assigned this Oct 18, 2020
@wb9688
Copy link
Contributor

wb9688 commented Oct 18, 2020

Code looks OK. Did you test on Android 4.4 and 11?

Edit: @Stypox did on 4.4, 7, and 10, so I think this would be good to merge.

@opusforlife2
Copy link
Collaborator

Can I merge? :3

@Stypox
Copy link
Member

Stypox commented Oct 18, 2020

@opusforlife2 yes ;-)

@Stypox Stypox removed their assignment Oct 18, 2020
@opusforlife2 opusforlife2 merged commit 9b9d267 into TeamNewPipe:dev Oct 18, 2020
@TacoTheDank
Copy link
Member Author

Wonderful, thanks!

@TacoTheDank TacoTheDank deleted the about-viewpager2 branch October 18, 2020 23:08
This was referenced Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants