Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use try-with-resources. #4815

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Use try-with-resources. #4815

merged 1 commit into from
Nov 21, 2020

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Use the try-with-resources feature, as enabling Java 8 support backports the functionality to API levels lower than 19, allowing it to be used in NewPipe Legacy.

APK testing

debug.zip

Due diligence

@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_try-with-resources branch 2 times, most recently from 4e92f93 to 5976b07 Compare November 19, 2020 02:05
Stypox
Stypox approved these changes Nov 21, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried all features you edited and they all work. Thank you for all of these codebase improvements! :-D

@Stypox Stypox merged commit a86ed1f into TeamNewPipe:dev Nov 21, 2020
@Isira-Seneviratne Isira-Seneviratne deleted the Use_try-with-resources branch November 25, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Isira-Seneviratne @Stypox