Improve performance for some updateState calls (local lists) #4891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This PR improves the binding for local list items (in playlist details and history) which require the progress time from streams (red indicator) by adding the field
progressTime
to some classes. The field is retrieved directly from the database and doesn't need to be fetched later (which blocked the UI by callingblockingGet
).With this change it is also easier to compare the items for changes more efficient when the lists are calculated asynchronously sometime in the future (e.g. through
ListAdapter
or Groupie).APK testing
app-debug.zip
Due diligence