Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various code improvements #4929

Merged
merged 11 commits into from
Nov 20, 2020
Merged

Various code improvements #4929

merged 11 commits into from
Nov 20, 2020

Conversation

TacoTheDank
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Death to lints!
  • Also updates Android Studio to 4.1.1

APK testing

app-debug.zip

Due diligence

TobiGr
TobiGr reviewed Nov 19, 2020
View reviewed changes
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me. Just a small thing

@TacoTheDank TacoTheDank requested a review from TobiGr November 19, 2020 23:56
@opusforlife2
Copy link
Collaborator

I would really suggest making your titles more descriptive of the actual PR. It makes it easier to read the release notes and prepare the blog post.

jimman2003
jimman2003 approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@jimman2003 jimman2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@TobiGr TobiGr changed the title A bunch of miscellaneous code improvements Various code improvements Nov 20, 2020
@TobiGr TobiGr merged commit bbfa280 into TeamNewPipe:dev Nov 20, 2020
@TacoTheDank
Copy link
Member Author

I would really suggest making your titles more descriptive of the actual PR. It makes it easier to read the release notes and prepare the blog post.

I'll try to remember this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr approved these changes

@jimman2003 jimman2003 jimman2003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TacoTheDank @opusforlife2 @TobiGr @jimman2003