Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Groupie's view binding module. #5029

Merged
merged 13 commits into from
Jan 16, 2021

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Nov 29, 2020

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Replace Groupie's Kotlin synthetics module with its view binding module, as synthetics have been deprecated starting with Kotlin 1.4.20.

APK testing

debug.zip

Due diligence

@vkay94
Copy link
Contributor

vkay94 commented Nov 29, 2020

Great :)

One though regarding ChannelItem:
Isn't it possible to stick to the single item by using Item<GroupieViewholder> and findViewById-pattern instead of splitting? The classes are basically identical except of the layout resource (less repeating code the better, right? :D) :)

@Isira-Seneviratne
Copy link
Member Author

Great :)

One though regarding ChannelItem:
Isn't it possible to stick to the single item by using Item<GroupieViewholder> and findViewById-pattern instead of splitting? The classes are basically identical except of the layout resource (less repeating code the better, right? :D) :)

I'll give it a try.

@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_Groupie_view_binding branch 2 times, most recently from 2546b44 to efee646 Compare December 16, 2020 01:03
@vkay94 vkay94 mentioned this pull request Dec 17, 2020
5 tasks
@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_Groupie_view_binding branch from 7535c5f to 1f99760 Compare January 2, 2021 03:56
@Stypox Stypox requested a review from vkay94 January 14, 2021 14:00
@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_Groupie_view_binding branch 2 times, most recently from 5db5f6c to 7c0dfcd Compare January 16, 2021 05:07
@vkay94
Copy link
Contributor

vkay94 commented Jan 16, 2021

Looks good.

@Stypox
Copy link
Member

Stypox commented Jan 16, 2021

I tested this, everything works fine in the subscriptions fragment. Thank you :-)

@Stypox Stypox merged commit 098c954 into TeamNewPipe:dev Jan 16, 2021
@Isira-Seneviratne Isira-Seneviratne deleted the Use_Groupie_view_binding branch January 17, 2021 00:26
This was referenced Jan 18, 2021
tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 20, 2021
…e_Groupie_view_binding

Switch to Groupie's view binding module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants