-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove timestamp from share url for all services except youtube #5228
Conversation
app/src/main/java/org/schabi/newpipe/player/VideoPlayerImpl.java
Outdated
Show resolved
Hide resolved
It produces not found error for PeerTube, media.ccc.de, SoundCloud
PeerTube sharing works like this https://framatube.org/videos/watch/9c9de5e8-0a1e-484a-b099-e80766180a6d?start=1m32s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in my opinion
@TobiGr please read the pr description |
@TobiGr that should be handled extractor-side, this is just a (hopefully temporary) workaround, so it shouldn't include timestamp share for all services |
I read the PR description. But why only fix the bug for YouTube and not for other services as well? |
@Stypox you are right, so that it doesn't break URLs |
What is it?
Description of the changes in your PR
Remove timestamp from share url unless it's youtube.
It produced not found error for PeerTube, media.ccc.de, SoundCloud.
Ideally we should implement this
#4316 (comment)
but it has been three months and no one is willing to work on this, then I'd like to get this PR merged for the next release.
Fixes the following issue(s)
APK testing
app-debug.zip
Due diligence