-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert AnimationUtils functions to extension functions. #5333
Convert AnimationUtils functions to extension functions. #5333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test everything that you changed? Since there are only very little unit tests, refactoring like this requires extensive manual testing.
app/src/main/java/org/schabi/newpipe/fragments/list/comments/CommentsFragment.java
Show resolved
Hide resolved
2521e39
to
590db7a
Compare
I made sure to preserve the existing behavior. Just to be sure, I tested it out and didn't find any issues. |
33cc190
to
f4dadf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small thing
Oh, then also |
f4dadf0
to
a98c0de
Compare
a98c0de
to
920e560
Compare
There doesn't seem to be a way to get a reference to the generated class for top-level declarations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. @TobiGr can this be merged?
I tested many places and everything seems to work well |
…nvert_AnimationUtils_to_extensions Convert AnimationUtils functions to extension functions.
What is it?
Description of the changes in your PR
AnimationUtils
to Kotlin extension functions.APK testing
debug.zip
Due diligence