Convert AnimationUtils functions to extension functions. #5333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiangRongLin
reviewed
Jan 4, 2021
app/src/main/java/org/schabi/newpipe/fragments/list/comments/CommentsFragment.java
Show resolved
Hide resolved
Isira-Seneviratne
force-pushed
the
Convert_AnimationUtils_to_extensions
branch
from
2521e39 to
590db7a
Compare
I made sure to preserve the existing behavior. Just to be sure, I tested it out and didn't find any issues. |
Isira-Seneviratne
force-pushed
the
Convert_AnimationUtils_to_extensions
branch
5 times, most recently
from
33cc190 to
f4dadf0
Compare
Stypox
previously approved these changes
Jan 16, 2021
|
Oh, then also |
Isira-Seneviratne
force-pushed
the
Convert_AnimationUtils_to_extensions
branch
from
f4dadf0 to
a98c0de
Compare
Isira-Seneviratne
force-pushed
the
Convert_AnimationUtils_to_extensions
branch
from
a98c0de to
920e560
Compare
There doesn't seem to be a way to get a reference to the generated class for top-level declarations. |
|
I tested many places and everything seems to work well |
ghost
mentioned this pull request
tossj
pushed a commit
to tossj/NewPipe-legacy
that referenced
this pull request
Apr 20, 2021
…nvert_AnimationUtils_to_extensions Convert AnimationUtils functions to extension functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
AnimationUtilsto Kotlin extension functions.APK testing
debug.zip
Due diligence