Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use view binding in remaining places. #5461

Closed
wants to merge 19 commits into from
Closed

Use view binding in remaining places. #5461

wants to merge 19 commits into from

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Use view binding in places where it wasn't being used yet, such as the dialogs.

Due diligence

@XiangRongLin XiangRongLin added the codequality Improvements to the codebase to improve the code quality label Jan 20, 2021
@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_view_binding_in_remaining_places branch 2 times, most recently from 012bc55 to 1bc59bb Compare January 28, 2021 03:10
@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_view_binding_in_remaining_places branch from 1bc59bb to 4964f21 Compare February 2, 2021 00:08
@Isira-Seneviratne Isira-Seneviratne mentioned this pull request Feb 2, 2021
Merged
5 tasks
@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_view_binding_in_remaining_places branch from 1fc4ce2 to 2b59689 Compare February 2, 2021 23:26
@Isira-Seneviratne
Use view binding in SuggestionListAdapter.
355e192
@Isira-Seneviratne
Use view binding in StreamItemAdapter.
c21d2cc
@Isira-Seneviratne
Use view binding in MissionsFragment and MissionAdapter.
29bd32f
@Isira-Seneviratne
Use view binding in PlaylistCreationDialog.
2b417f6
@Isira-Seneviratne
Use view binding in AddTabDialog.
a8e2a17
@Isira-Seneviratne
Use view binding in InfoItemDialog.
d765fba
@Isira-Seneviratne
Use view binding in PlaybackParameterDialog.
6aca797
@Isira-Seneviratne
Use view binding in LocalPlaylistFragment.
9522fe4
@Isira-Seneviratne
Use view binding in ChooseTabsFragment.
0d896ab
@Isira-Seneviratne
Use SubscriptionImportExportItemBinding in FeedImportExportItem.
7611f7a
@Isira-Seneviratne
Use ToolbarSearchLayoutBinding in SearchFragment.
2174863
@Isira-Seneviratne
Use view binding in StreamSegmentItem.
aa631cd
@Isira-Seneviratne
Add calls to 'metadataView' in Player.
8919580
@Isira-Seneviratne
Use view binding in PlaylistAppendDialog.
611ba56
@Isira-Seneviratne
Use view binding in BookmarkFragment.
42a910b
@Isira-Seneviratne
Use view binding in PlayQueueItemHolder.
250b307
@Isira-Seneviratne
Use view binding in SelectPlaylistFragment.
43fcc69
@Isira-Seneviratne
Use view binding in PeertubeInstanceListFragment.
8caeab7
@Isira-Seneviratne
Set the Fragment view bindings to null after the CompositeDisposables…
c8edab0 
… have been cleared.
@Isira-Seneviratne Isira-Seneviratne force-pushed the Use_view_binding_in_remaining_places branch from 2b59689 to c8edab0 Compare February 4, 2021 08:10
@Isira-Seneviratne Isira-Seneviratne deleted the Use_view_binding_in_remaining_places branch February 26, 2021 02:57
@Isira-Seneviratne Isira-Seneviratne restored the Use_view_binding_in_remaining_places branch February 26, 2021 02:58
@Isira-Seneviratne Isira-Seneviratne deleted the Use_view_binding_in_remaining_places branch July 12, 2021 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Isira-Seneviratne @XiangRongLin