Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update check] Add cool down on server-side problems #5515

Closed
wants to merge 1 commit into from

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Jan 31, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Reduce load on API when checking for new version. When the last request failed, there is no cool down stored, so the app will make a new request once the app is restarted.
Add a cooldown of one hour before a new request is made

Follow up to #5474

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@TobiGr TobiGr changed the title [Ipdate check] Add cool down no sever side problems [Update check] Add cool down no sever side problems Jan 31, 2021
@TobiGr TobiGr changed the title [Update check] Add cool down no sever side problems [Update check] Add cool down on sever side problems Jan 31, 2021
Copy link
Collaborator

@XiangRongLin XiangRongLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all 4xx 5xx status codes evaluated as error and go into the error block?

@XiangRongLin XiangRongLin added the bug Issue is related to a bug label Jan 31, 2021
@TobiGr TobiGr force-pushed the dev branch 2 times, most recently from 679bc75 to 2aeccc0 Compare March 16, 2021 08:24
@litetex
Copy link
Member

litetex commented Oct 10, 2021

Is this PR still a thing?
There have been massive changes to the Updatecheck in #6980

@opusforlife2
Copy link
Collaborator

@TobiGr ^

@litetex litetex marked this pull request as draft November 21, 2021 19:10
@litetex
Copy link
Member

litetex commented Nov 21, 2021

Converted to draft due to no activity and merge problems.

@opusforlife2 opusforlife2 changed the title [Update check] Add cool down on sever side problems [Update check] Add cool down on server-side problems Nov 21, 2021
@TobiGr TobiGr closed this Dec 22, 2021
@litetex litetex deleted the api_error_cooldown branch February 26, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants