Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open in browser option to long-press menu #6280

Merged
merged 2 commits into from
Jun 3, 2021
+12 −4
Merged

Add Open in browser option to long-press menu #6280

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9aaafd
Add Open in browser option to long-press menu
AudricV May 13, 2021
b4d6015
Add the Open in browser option when long-pressing a stream for local …
AudricV May 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add Open in browser option to long-press menu 
Add Open in browser option to long-press menu when long pressing a stream and a subscription
@AudricV
AudricV committed Jun 3, 2021

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: E6D3E7F5949450DD
Learn about vigilant mode
commit b9aaafdb30324b7460e73170eedfbd20ebf4a167
2 changes: 1 addition & 1 deletion app/src/main/java/org/schabi/newpipe/fragments/list/BaseListFragment.java
View file
Original file line number Diff line number Diff line change
@@ -370,10 +370,10 @@ protected void showStreamDialog(final StreamInfoItem item) {
StreamDialogEntry.share
));
}
entries.add(StreamDialogEntry.open_in_browser);
if (KoreUtil.shouldShowPlayWithKodi(context, item.getServiceId())) {
entries.add(StreamDialogEntry.play_with_kodi);
}

if (!isNullOrEmpty(item.getUploaderUrl())) {
entries.add(StreamDialogEntry.show_channel_details);
}
6 changes: 4 additions & 2 deletions app/src/main/java/org/schabi/newpipe/local/subscription/SubscriptionFragment.kt
View file
Original file line number Diff line number Diff line change
@@ -294,12 +294,14 @@ class SubscriptionFragment : BaseStateFragment<SubscriptionState>() {
}

private fun showLongTapDialog(selectedItem: ChannelInfoItem) {
val commands = arrayOf(getString(R.string.share), getString(R.string.unsubscribe))
val commands = arrayOf(getString(R.string.share), getString(R.string.open_in_browser),
getString(R.string.unsubscribe))

val actions = DialogInterface.OnClickListener { _, i ->
when (i) {
0 -> ShareUtils.shareText(requireContext(), selectedItem.name, selectedItem.url)
1 -> deleteChannel(selectedItem)
1 -> ShareUtils.openUrlInBrowser(requireContext(), selectedItem.url)
2 -> deleteChannel(selectedItem)
}
}

5 changes: 4 additions & 1 deletion app/src/main/java/org/schabi/newpipe/util/StreamDialogEntry.java
View file
Original file line number Diff line number Diff line change
@@ -87,7 +87,10 @@ public enum StreamDialogEntry {
}),

share(R.string.share, (fragment, item) ->
ShareUtils.shareText(fragment.getContext(), item.getName(), item.getUrl()));
ShareUtils.shareText(fragment.getContext(), item.getName(), item.getUrl())),

open_in_browser(R.string.open_in_browser, (fragment, item) ->
ShareUtils.openUrlInBrowser(fragment.getContext(), item.getUrl()));


///////////////