Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade ExoPlayer to 2.12 #6294

Merged
merged 1 commit into from
May 15, 2021
Merged

Downgrade ExoPlayer to 2.12 #6294

merged 1 commit into from
May 15, 2021

Conversation

Redirion
Copy link
Member

@Redirion Redirion commented May 14, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Downgrade to fix performance issues with LineageOS

Fixes the following issue(s)

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@Redirion Redirion changed the title TEST: Downgrade ExoPlayer to 2.12 Downgrade ExoPlayer to 2.12 May 14, 2021
@Redirion Redirion marked this pull request as ready for review May 14, 2021 22:13
@TobiGr TobiGr added bug Issue is related to a bug player Issues related to any player (main, popup and background) labels May 15, 2021
@TobiGr TobiGr merged commit 5eb5dbd into TeamNewPipe:dev May 15, 2021
@Redirion Redirion deleted the exodowngrade branch May 15, 2021 23:15
This was referenced May 23, 2021
@TobiGr
Copy link
Contributor

TobiGr commented Aug 22, 2021

I think we can revert this PR as exoplayer was not the cause of the problem

@Redirion
Copy link
Member Author

It is. Devices that do not report correct media codec level support will have a stuttering issue again as described in the references issue. But we could of course say, that's their problem, as it could be fixed in LineageOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.21.2 video playback performance regression
2 participants