Load uploaderUrl when showing Channel Details from Play Queue

[ktprograms]

This checks if the uploaderUrl is in the database, if not it gets the
uploaderUrl and puts it in the database. This is similar to the fetching
of uploaderUrl when it doesn't exist done in #6919.

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Move the code that conditionally fetches the uploaderUrl and saves it to the database into a helper class + method.
• Use the saveUploaderUrlIfNeeded method in QueueItemMenuUtil when selecting Show Channel Details in order to load the uploaderUrl if it isn't available in the database.

Before/After Screenshots/Screen Record

Android Emulator screen recording seems to be broken, I'll do my best to describe the before and after in text.

• Before: When selecting Show Channel Details on a video that doesn't have uploaderUrl in the database, it will go to the channel fragment, but the uploaderUrl will be null, so it will cause a network error.
• After: When selecting Show Channel Details on a video that doesn't have uploaderUrl in the database, it will fetch the uploaderUrl and display a loading toast, then open the channel fragment.

Fixes the following issue(s)

Did not find any issues that will be fixed by this PR.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[litetex]

Detected a TODO: https://github.com/TeamNewPipe/NewPipe/pull/7538/files#diff-212f79b4111281cdfbffed5f79bca8922f99be14642ef90d524e6c9de9a436f7R61

Assuming this PR is not yet in a reviewable state and converted it to a draft.

[ktprograms]

@litetex This TODO was from the previous PR (#6919), and it isn't critical to operation of this functionality.

I can't figure out how to open the Error Activity, can you either give an example code or link to some code that does this?

[litetex]

@ktprograms

I can't figure out how to open the Error Activity, can you either give an example code or link to some code that does this?

Basically take a look at the ErrorUtil class
Stypox refactored that recently, you may also checkout #7482; There are some usage examples 😄

[ktprograms]

@litetex Unfortunately, I'm not sure there's a good way to show the error.

Using ErrorUtil opens the full blown error reporting activity, which isn't necessary since most of the time it would be a network error which can be retried.

I tried using ErrorPanelHelper, but that doesn't work because this part of the code doesn't have access to a Fragment.

I also can't use ErrorUtil.showSnackbar because it can't seem to find the correct rootView.

[litetex]

@Stypox

I also can't use ErrorUtil.showSnackbar because it can't seem to find the correct rootView.

Do you have an idea how to fix this?

[Stypox]

@ktprograms I don't know if it would be possible to open a snackbar in that case. In order to open a snackbar you need a Context which is instanceof Activity, or a Fragment. Only in those cases (and if the activity/fragment has a valid rootView, which it usually has) can the snackbar be shown. But since you call showSnackbar with a "random" Context that might not be instanceof Activity, it won't work. Note that Fragment.getContext() does not necessarily return a Context which is instanceof Activity, only Fragment.getActivity() does, if != null. So if you might need to change the methods you created a bit, in order to make sure not to pass fragment.getContext() to showSnackbar but pass the original fragment instead. Also, you should ensure that the context in QueueItemMenuUtil is instanceof Activity; if is not always such, also change QueueItemMenuUtil.openPopupMenu accordingly.

If doing these things turns out to require changing too many lines and duplicate too much code, just use an error notification, that can be shown just by using a context.

[ktprograms]

@Stypox I'll look more into this tomorrow, but what do you mean by just use an error notification? Do you mean just standard Android notifications or something else?

[ktprograms]

Would it be better to merge this first as it fixes the bug that the channel details aren't properly loaded, and move the error handling to another PR? (BTW the TODO was from my first PR about Show Channel Details)

[Stypox]

@ktprograms just replace ErrorUtil.showSnackbar(context, errorInfo) with ErrorUtil.createNotification(context, errorInfo)

[ktprograms]

replace ErrorUtil.showSnackbar(context, errorInfo) with ErrorUtil.createNotification(context, errorInfo)

Done. Ready for review, please.

[opusforlife2]

Done. Ready for review, please.

Then this doesn't need to be a draft anymore.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

[ktprograms]

How would I fix this warning: https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AX6PN5ztwvdSy9w-T0sr&open=AX6PN5ztwvdSy9w-T0sr&pullRequest=7538 ? It is in the else branch of isNullOrEmpty so it can't be null, but how do I indicate that to the analysis?

[XiangRongLin]

How would I fix this warning: https://sonarcloud.io/project/issues?id=TeamNewPipe_NewPipe&issues=AX6PN5ztwvdSy9w-T0sr&open=AX6PN5ztwvdSy9w-T0sr&pullRequest=7538 ? It is in the else branch of isNullOrEmpty so it can't be null, but how do I indicate that to the analysis?

That does not seem to be possible for you: https://community.sonarsource.com/t/sonarqube-does-not-detect-null-check-by-a-method-and-showing-possible-nullpointerexception/28809
I marked it as false positive for now

[ktprograms]

Ok, thanks!

[Stypox]

Code looks good, thank you! I tested and it works well (even though now the problem with QueueItemMenuUtil is already disappeared thanks to #7036 which makes sure items with full stream info to be enqueued).

[ktprograms]

Thanks!