Bump minSdk to 21 - Android 5 / Lollipop #7613

litetex · 2022-01-03T13:10:31Z

What is it?

Bugfix (user facing)
Feature (user facing)
Codebase improvement (dev facing)
Meta improvement to the project (dev facing)

Description of the changes in your PR

Bump minSdk to 21 - Android 5 / Lollipop - Dropped support for Android 4.4 and removed all corresponding code snippets

Fixes the following issue(s)

Fixes Drop support for Android 4.4 / Require Android 5 / API 21 #7602

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

I read the contribution guidelines.

Fs00 · 2022-01-03T17:41:05Z

There also resources in values-v21 and values-night-v21 folders that can be put into their corresponding files in values folder.

litetex · 2022-01-04T14:47:17Z

@Fs00

Thank you for the hint.
I consolidated the styles 😄

Fs00 · 2022-01-04T15:19:56Z

Great! After a quick look at the code I've found other things that are unnecessary on API 21+:

AndroidX Multidex library and its relative multiDexEnabled config parameter are not needed anymore, since Android 5+ natively supports multiple DEX files
Vector drawables backwards-compatibility (enabled here) can be disabled (vector are natively supported on Android 5+) and usages of attribute app:srcCompat need to be replaced with android:src

TobiGr · 2022-01-04T16:13:25Z

Please also check whether we can disable coreLibraryDesugraing. That is crushing reporoducible / deterministic builds (see #6486).

Are you going to upgrade okHttp in this PR?

litetex · 2022-01-04T16:42:06Z

Thank you guys for the hints, I will have a look.

Are you going to upgrade okHttp in this PR?

No that should be a new one. I'm just dropping 4.4 here 😄

litetex · 2022-01-04T17:29:09Z

Please also check whether we can disable coreLibraryDesugraing. That is crushing reproducible / deterministic builds (see #6486).

This is not possible.
Otherwise the app crashes on devices < Android 8 / API 26 because Java 8 features are missing.

Fun Fact: Compiling works execution not

01/04 18:26:38: Launching 'app' on Pixel 3a API 22.
Install successfully finished in 28 s 40 ms.
$ adb shell am start -n "org.schabi.newpipe.debug.increaseminsdk/org.schabi.newpipe.MainActivity" -a android.intent.action.MAIN -c android.intent.category.LAUNCHER
Connected to process 5554 on device 'Pixel_3a_API_22 [emulator-5556]'.
Connected to process 5624 on device 'Pixel_3a_API_22 [emulator-5556]'.
Capturing and displaying logcat messages from application. This behavior can be disabled in the "Logcat output" section of the "Debugger" settings page.
I/ACRA: ACRA is enabled for org.schabi.newpipe.debug.increaseminsdk, initializing...
D/InfoCache: clearCache() called
I/art: Rejecting re-init on previously-failed class java.lang.Class<org.ocpsoft.prettytime.PrettyTime$$ExternalSyntheticLambda0>
    Rejecting re-init on previously-failed class java.lang.Class<org.ocpsoft.prettytime.PrettyTime$$ExternalSyntheticLambda0>
D/LeakCanary: Updated AppWatcher.config: Config(watchDurationMillis=10000)
I/stetho: Listening on @stetho_org.schabi.newpipe.debug.increaseminsdk_devtools_remote
D/LeakCanary: Updated LeakCanary.config: Config(dumpHeap=false)
D/AndroidRuntime: Shutting down VM
E/ACRA: ACRA caught a NoClassDefFoundError for org.schabi.newpipe.debug.increaseminsdk
    java.lang.NoClassDefFoundError: Failed resolution of: Ljava/time/format/DateTimeFormatter;
        at org.schabi.newpipe.error.ErrorActivity.<clinit>(ErrorActivity.java:72)
        at java.lang.reflect.Constructor.newInstance(Native Method)
        at java.lang.Class.newInstance(Class.java:1606)
        at android.app.Instrumentation.newActivity(Instrumentation.java:1066)
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2226)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2387)
        at android.app.ActivityThread.access$800(ActivityThread.java:151)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1303)
        at android.os.Handler.dispatchMessage(Handler.java:102)
        at android.os.Looper.loop(Looper.java:135)
        at android.app.ActivityThread.main(ActivityThread.java:5254)
        at java.lang.reflect.Method.invoke(Native Method)
        at java.lang.reflect.Method.invoke(Method.java:372)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
     Caused by: java.lang.ClassNotFoundException: Didn't find class "java.time.format.DateTimeFormatter" on path: DexPathList[[zip file "/data/app/org.schabi.newpipe.debug.increaseminsdk-1/base.apk"],nativeLibraryDirectories=[/vendor/lib64, /system/lib64]]
        at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:56)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:511)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:469)
        at org.schabi.newpipe.error.ErrorActivity.<clinit>(ErrorActivity.java:72) 
        at java.lang.reflect.Constructor.newInstance(Native Method) 
        at java.lang.Class.newInstance(Class.java:1606) 
        at android.app.Instrumentation.newActivity(Instrumentation.java:1066) 
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2226) 
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2387) 
        at android.app.ActivityThread.access$800(ActivityThread.java:151) 
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1303) 
        at android.os.Handler.dispatchMessage(Handler.java:102) 
        at android.os.Looper.loop(Looper.java:135) 
        at android.app.ActivityThread.main(ActivityThread.java:5254) 
        at java.lang.reflect.Method.invoke(Native Method) 
        at java.lang.reflect.Method.invoke(Method.java:372) 
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903) 
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698) 
    	Suppressed: java.lang.ClassNotFoundException: java.time.format.DateTimeFormatter
        at java.lang.Class.classForName(Native Method)
        at java.lang.BootClassLoader.findClass(ClassLoader.java:781)
        at java.lang.BootClassLoader.loadClass(ClassLoader.java:841)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:504)
        		... 16 more
     Caused by: java.lang.NoClassDefFoundError: Class not found using the boot class loader; no stack available
Connected to process 5760 on device 'Pixel_3a_API_22 [emulator-5556]'.
Capturing and displaying logcat messages from application. This behavior can be disabled in the "Logcat output" section of the "Debugger" settings page.
I/ACRA: ACRA is enabled for org.schabi.newpipe.debug.increaseminsdk, initializing...
D/InfoCache: clearCache() called
I/art: Rejecting re-init on previously-failed class java.lang.Class<org.ocpsoft.prettytime.PrettyTime$$ExternalSyntheticLambda0>
    Rejecting re-init on previously-failed class java.lang.Class<org.ocpsoft.prettytime.PrettyTime$$ExternalSyntheticLambda0>
D/LeakCanary: Updated AppWatcher.config: Config(watchDurationMillis=10000)
I/stetho: Listening on @stetho_org.schabi.newpipe.debug.increaseminsdk_devtools_remote
D/LeakCanary: Updated LeakCanary.config: Config(dumpHeap=false)
D/AndroidRuntime: Shutting down VM
E/ACRA: ACRA caught a NoClassDefFoundError for org.schabi.newpipe.debug.increaseminsdk
    java.lang.NoClassDefFoundError: Failed resolution of: Ljava/time/format/DateTimeFormatter;
        at org.schabi.newpipe.error.ErrorActivity.<clinit>(ErrorActivity.java:72)
        at java.lang.reflect.Constructor.newInstance(Native Method)
        at java.lang.Class.newInstance(Class.java:1606)
        at android.app.Instrumentation.newActivity(Instrumentation.java:1066)
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2226)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2387)
        at android.app.ActivityThread.access$800(ActivityThread.java:151)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1303)
        at android.os.Handler.dispatchMessage(Handler.java:102)
        at android.os.Looper.loop(Looper.java:135)
        at android.app.ActivityThread.main(ActivityThread.java:5254)
        at java.lang.reflect.Method.invoke(Native Method)
        at java.lang.reflect.Method.invoke(Method.java:372)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
     Caused by: java.lang.ClassNotFoundException: Didn't find class "java.time.format.DateTimeFormatter" on path: DexPathList[[zip file "/data/app/org.schabi.newpipe.debug.increaseminsdk-1/base.apk"],nativeLibraryDirectories=[/vendor/lib64, /system/lib64]]
        at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:56)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:511)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:469)
        at org.schabi.newpipe.error.ErrorActivity.<clinit>(ErrorActivity.java:72) 
        at java.lang.reflect.Constructor.newInstance(Native Method) 
        at java.lang.Class.newInstance(Class.java:1606) 
        at android.app.Instrumentation.newActivity(Instrumentation.java:1066) 
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2226) 
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2387) 
        at android.app.ActivityThread.access$800(ActivityThread.java:151) 
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1303) 
        at android.os.Handler.dispatchMessage(Handler.java:102) 
        at android.os.Looper.loop(Looper.java:135) 
        at android.app.ActivityThread.main(ActivityThread.java:5254) 
        at java.lang.reflect.Method.invoke(Native Method) 
        at java.lang.reflect.Method.invoke(Method.java:372) 
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903) 
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698) 
    	Suppressed: java.lang.ClassNotFoundException: java.time.format.DateTimeFormatter
        at java.lang.Class.classForName(Native Method)
        at java.lang.BootClassLoader.findClass(ClassLoader.java:781)
        at java.lang.BootClassLoader.loadClass(ClassLoader.java:841)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:504)
        		... 16 more
     Caused by: java.lang.NoClassDefFoundError: Class not found using the boot class loader; no stack available

Fs00 · 2022-01-04T22:43:00Z

@litetex It just came to my mind that if you disable vector drawables backwards compatibility, you need also to replace app:drawableXXXCompat attributes with their android:drawableXXX counterpart (I've seen that there are some usages of those in NewPipe).

litetex · 2022-01-05T14:15:15Z

@litetex It just came to my mind that if you disable vector drawables backwards compatibility, you need also to replace app:drawableXXXCompat attributes with their android:drawableXXX counterpart (I've seen that there are some usages of those in NewPipe).

When I don't replace the app:drawableXXXCompat the app works as expected and there is also no warning inside Android studio.

~~Could you add a reference where it is stated that you should rather use android:drawableXXX instead of app:drawableXXXCompat?~~
→ https://stackoverflow.com/questions/63479754/getting-appdrawableendcompat-instead-of-androiddrawableend-warning-for-lollipo

Anyway, I replaced the usages now.

sonarqubecloud · 2022-01-05T14:24:35Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

Plugdemholes-Imeanpatchdembugs · 2022-01-05T21:27:13Z

Will there be a new seperate downloadable Legacy release for the last version that supported Android 4.4?
Would be a shame if this new Legacy release would just replace the old one, considering the last Legacy release for Android 4.1 still seems to work.

Asking because when I'm checking the changelog and the version of the current Legacy release, there doesn't seem to be any indication in the changelog that there was a change in minSdk in version 0.20.9 ?.?

opusforlife2 · 2022-01-06T19:21:00Z

This will only be required once a security issue is found in OkHttp 3.x, right? What I mean is, could we keep releasing new versions with Kitkat support until we are forced to upgrade OkHttp to 4.x?

Stypox · 2022-01-07T21:19:19Z

@opusforlife2 since OkHttp 3.x is now not supported anymore, it's just a matter of time before a vulnerability is found, and it would be difficult to know that a new vulnerability was found. So it is a good idea imo to just drop support for 4.4, upgrade to OkHttp 4.x and stay on the safe side

TacoTheDank · 2022-01-07T22:33:50Z

This is indeed a cause for celebration!

I can think of a few other compatibility things that can be removed, but they aren't that important. I can just create a PR for those if we do decide to go forward with dropping all legacy support (everything < 21, including NewPipe Legacy).

opusforlife2 · 2022-01-08T10:33:33Z

So it is a good idea imo to just drop support for 4.4, upgrade to OkHttp 4.x and stay on the safe side

In that case, considering that 19 PRs are already merged for the next version, maybe we should only merge this PR and release ASAP.

app/src/main/java/org/schabi/newpipe/error/ReCaptchaActivity.java

Stypox

Looks mostly good to me

app/src/main/java/org/schabi/newpipe/error/ReCaptchaActivity.java

app/src/main/res/layout/fragment_instance_list.xml

app/src/main/res/layout/list_comments_item.xml

app/src/main/res/layout/list_comments_mini_item.xml

app/src/main/res/values/styles_services.xml

TacoTheDank · 2022-07-05T23:12:56Z

@litetex Could I rebase this PR to fix the conflicts?

litetex · 2022-07-06T17:24:14Z

@TacoTheDank Feel free to do so but note that this PR was create some months ago.
There are also certainly other things that need to be adjusted.

litetex

@TacoTheDank
Are you finished with your changes?

If there is nothing additional to do I think we can merge the branch.

opusforlife2 · 2022-07-10T17:37:25Z

Are we done with all the stuff that was proposed to be merged before removing Kitkat support? I can't exactly remember what those things were, though I think DASH and new stream notifications were two of them.

Stypox · 2022-07-11T16:42:28Z

@opusforlife2 yes, we are done; there has been a recent discussion about whether to also wait for tex's DASH-2, but we decided not to wait any longer.

Stypox

Took a look at the code, lgtm, thank you to everyone involved!

TacoTheDank · 2022-07-11T20:32:55Z

@TacoTheDank Are you finished with your changes?

If there is nothing additional to do I think we can merge the branch.

Yep, all done!

Stypox · 2022-07-13T17:09:00Z

I tested some misc things and could not find issues

sonarqubecloud · 2022-07-13T17:15:06Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

opusforlife2 · 2022-07-17T17:04:31Z

about whether to also wait for tex's DASH-2, but we decided not to wait any longer.

Isn't that purely the extractor? Extractor changes shouldn't have any influence on Legacy, no? I was under the impression that the front-end is what differs between NP and Legacy, which is why we wanted to add some critical front-end PRs before bumping.

Is that not the case?

Stypox · 2022-07-18T21:42:03Z

@opusforlife2 no, DASH-2 will also require big front-end changes because the extractor API will be changing again

litetex marked this pull request as ready for review January 9, 2022 13:11

litetex mentioned this pull request Jan 9, 2022

Made preferences searchable #7586

Merged

5 tasks

johnth3doe mentioned this pull request Jan 16, 2022

[Request/Query]RE: Future support for legacy (devices)? XiangRongLin/NewPipe-preuinified#15

Closed

TobiGr mentioned this pull request Jan 29, 2022

Is this version dead? TeamNewPipe/NewPipe-legacy#74

Open

This comment was marked as off-topic.

Sign in to view

litetex force-pushed the increase-minsdk branch 2 times, most recently from 47fea6e to 4278844 Compare February 28, 2022 18:47

litetex marked this pull request as draft February 28, 2022 19:11

litetex marked this pull request as ready for review February 28, 2022 19:16

TacoTheDank reviewed Mar 1, 2022

View reviewed changes

app/src/main/java/org/schabi/newpipe/error/ReCaptchaActivity.java Outdated Show resolved Hide resolved

Stypox requested changes Mar 3, 2022

View reviewed changes

Stypox mentioned this pull request Mar 3, 2022

Fix error notification on KitKat #7977

Merged

5 tasks

TacoTheDank added the codequality Improvements to the codebase to improve the code quality label Mar 6, 2022

litetex mentioned this pull request Mar 13, 2022

Google forced Vanced to shut down. Could NewPipe be next? #8025

Closed

3 tasks

litetex force-pushed the increase-minsdk branch from 53bd586 to f3c5cc6 Compare March 15, 2022 17:16

litetex mentioned this pull request Mar 15, 2022

Replace tls configuration with NetCipher for all Android versions #7372

Closed

5 tasks

TacoTheDank force-pushed the increase-minsdk branch 3 times, most recently from 9600dee to fc28e96 Compare July 6, 2022 21:49

litetex commented Jul 10, 2022

View reviewed changes

Stypox approved these changes Jul 11, 2022

View reviewed changes

This comment was marked as spam.

Sign in to view

litetex and others added 7 commits July 13, 2022 19:02

Bump minSdk to 21 (Android 5 / Lollipop)

e55e79b

Remove MultiDex

7cb137a

Clean up pre-Lollipop checks

99104fc

Clean up pre-Lollipop compat attributes

b125780

Clean up pre-Lollipop theming

9648525

Remove AndroidX Webkit

4ec9cbe

More minSdk 21 cleanup

189c92a

Stypox force-pushed the increase-minsdk branch from fc28e96 to 189c92a Compare July 13, 2022 17:04

Stypox merged commit bc37312 into TeamNewPipe:dev Jul 13, 2022

TacoTheDank mentioned this pull request Jul 14, 2022

Update OkHttp to 4.10.0 #8624

Merged

5 tasks

triallax mentioned this pull request Jul 14, 2022

Use tint methods. #8405

Closed

5 tasks

litetex deleted the increase-minsdk branch July 15, 2022 17:24

TacoTheDank mentioned this pull request Jul 17, 2022

Bump minSdk to 21 / Drop support for KitKat and below twireapp/Twire#362

Closed

Stypox mentioned this pull request Aug 27, 2022

Release v0.24.0 (please TEST!) #8890

Closed

9 tasks

flexagoon mentioned this pull request Sep 26, 2022

Wrong minimum version information TeamNewPipe/website#300

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump minSdk to 21 - Android 5 / Lollipop #7613

Bump minSdk to 21 - Android 5 / Lollipop #7613

litetex commented Jan 3, 2022

Fs00 commented Jan 3, 2022

litetex commented Jan 4, 2022

Fs00 commented Jan 4, 2022 •

edited

Loading

TobiGr commented Jan 4, 2022

litetex commented Jan 4, 2022

litetex commented Jan 4, 2022

Fs00 commented Jan 4, 2022 •

edited

Loading

litetex commented Jan 5, 2022

sonarqubecloud bot commented Jan 5, 2022

Plugdemholes-Imeanpatchdembugs commented Jan 5, 2022

opusforlife2 commented Jan 6, 2022

Stypox commented Jan 7, 2022

TacoTheDank commented Jan 7, 2022 •

edited

Loading

opusforlife2 commented Jan 8, 2022

This comment was marked as off-topic.

Stypox left a comment

TacoTheDank commented Jul 5, 2022

litetex commented Jul 6, 2022

litetex left a comment

opusforlife2 commented Jul 10, 2022

Stypox commented Jul 11, 2022

Stypox left a comment

This comment was marked as spam.

TacoTheDank commented Jul 11, 2022

Stypox commented Jul 13, 2022

sonarqubecloud bot commented Jul 13, 2022

opusforlife2 commented Jul 17, 2022

Stypox commented Jul 18, 2022

Bump minSdk to 21 - Android 5 / Lollipop #7613

Bump minSdk to 21 - Android 5 / Lollipop #7613

Conversation

litetex commented Jan 3, 2022

What is it?

Description of the changes in your PR

Fixes the following issue(s)

APK testing

Due diligence

Fs00 commented Jan 3, 2022

litetex commented Jan 4, 2022

Fs00 commented Jan 4, 2022 • edited Loading

TobiGr commented Jan 4, 2022

litetex commented Jan 4, 2022

litetex commented Jan 4, 2022

Fs00 commented Jan 4, 2022 • edited Loading

litetex commented Jan 5, 2022

sonarqubecloud bot commented Jan 5, 2022

Plugdemholes-Imeanpatchdembugs commented Jan 5, 2022

opusforlife2 commented Jan 6, 2022

Stypox commented Jan 7, 2022

TacoTheDank commented Jan 7, 2022 • edited Loading

opusforlife2 commented Jan 8, 2022

This comment was marked as off-topic.

Stypox left a comment

Choose a reason for hiding this comment

TacoTheDank commented Jul 5, 2022

litetex commented Jul 6, 2022

litetex left a comment

Choose a reason for hiding this comment

opusforlife2 commented Jul 10, 2022

Stypox commented Jul 11, 2022

Stypox left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

TacoTheDank commented Jul 11, 2022

Stypox commented Jul 13, 2022

sonarqubecloud bot commented Jul 13, 2022

opusforlife2 commented Jul 17, 2022

Stypox commented Jul 18, 2022

Fs00 commented Jan 4, 2022 •

edited

Loading

Fs00 commented Jan 4, 2022 •

edited

Loading

TacoTheDank commented Jan 7, 2022 •

edited

Loading