Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AGP and Gradle #7947

Merged
merged 1 commit into from
Feb 27, 2022
Merged

Conversation

TacoTheDank
Copy link
Member

@TacoTheDank TacoTheDank commented Feb 26, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Update Gradle (and the wrapper) to 7.4 using git bash (changelog)
  • Update AGP 7.0.4 -> 7.1.2 (see here and here)
  • Bump buildTools 30.0.3 -> 31.0.0

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Stypox
Copy link
Member

Stypox commented Feb 26, 2022

I get the usual error that has keeps popping up in Android Studio lately, I still didn't understand if it can be ignored as an AS bug, if it something I should solve inside my configuration or if it is a problem with the NewPipe repository:

10:42	Gradle sync failed: It is not fully supported to define distributionSha256Sum in gradle/wrapper/gradle-wrapper.properties.
			Using an incorrect value may freeze or crash Android Studio.
			Please manually verify or remove this property from all of included projects if applicable.
			For more details, see https://github.com/gradle/gradle/issues/9361.
			Use "cd5c2958a..." as checksum for https://services.gradle.org/distributions/gradle-7.4-all.zip and sync project
			Remove distributionSha256Sum and sync project
			Open Gradle wrapper properties (36 s 293 ms)

After having clicked on Use "cd5c2958a..." as checksum for https://services.gradle.org/distributions/gradle-7.4-all.zip and sync project the sync succeeded and I could build the app without issues and run it in an emulator, so I guess this PR is good to go.

Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Checked out the branch
  • Ran a build
  • Deployed the app to an emulator
  • Everything works fine ✔️

@TacoTheDank
Copy link
Member Author

@Stypox I get that too. I just click on "use..." and it goes away 🤷

@litetex litetex merged commit fd6c352 into TeamNewPipe:dev Feb 27, 2022
@TacoTheDank TacoTheDank deleted the bumpPluginsNGradle branch February 27, 2022 17:08
@Stypox Stypox mentioned this pull request Apr 16, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants