Refactor VideoDetailFragment. #8847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
Isira-Seneviratne
force-pushed
the
Refactor_VideoDetailFragment
branch
2 times, most recently
from
be39436 to
6501ddb
Compare
Isira-Seneviratne
force-pushed
the
Refactor_VideoDetailFragment
branch
from
6501ddb to
5102c45
Compare
Isira-Seneviratne
force-pushed
the
Refactor_VideoDetailFragment
branch
from
b40eb47 to
9d7903c
Compare
|
It seems like the player crashes (though without a notification) when entering or leaving fullscreen. |
Thanks for the feedback, will look into this. |
Isira-Seneviratne
force-pushed
the
Refactor_VideoDetailFragment
branch
from
9d7903c to
cf36101
Compare
|
I undid the view model changes in this PR, I'll make them in a separate one. |
Isira-Seneviratne
force-pushed
the
Refactor_VideoDetailFragment
branch
from
cf36101 to
e4f9746
Compare
|
It seems to be working fine in general now. |
For consistency with long click listeners, in VideoDetailFragment
|
Kudos, SonarCloud Quality Gate passed! |
Stypox
approved these changes
Dec 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
VideoDetailFragment.Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence