Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set image-minimizer to specify image width ... #9470

Closed
wants to merge 3 commits into from

Conversation

goyalyashpal
Copy link
Contributor

@goyalyashpal goyalyashpal commented Nov 26, 2022

Fix #9469 for portrait like orientations

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • set the width of the image, instead of the height
    see the rationale mentioned in the linked issue

Before/After Screenshots/Screen Record

  • Before:
BEFORE_SET-HEIGHT.vivaldi_O2sZYxLU3D.mp4
  • After:
AFTER_SET-WIDTH.vivaldi_ES6z2h4j6t.mp4

Fixes the following issue(s)

APK testing

Sorry, couldn't rename the branch now, github doesn't detect it.

Due diligence

@goyalyashpal
Copy link
Contributor Author

goyalyashpal commented Nov 26, 2022

Please do check this if this is correct, i have not tested as i did.... umh, wait...

Edit: yeah, as i don't know how to test this.

i thought to open an issue in that repo, but the action didn't seem to be triggered for some reason: https://github.com/yashpalgoyal1304/NewPipe/issues/1
oh wait, obviously the action won't trigger as the changes are not in the default repo 🤦

yeah, so, i made this my base repository, and reuploaded a wide image, but it still didn't trigger the actions-bot

@opusforlife2
Copy link
Collaborator

You could spend 30 seconds to clean up the default template text...

@goyalyashpal goyalyashpal marked this pull request as draft November 26, 2022 18:43
@goyalyashpal
Copy link
Contributor Author

You could spend 30 seconds to clean up the default template text...

it requires data, which i am gathering currently

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@goyalyashpal goyalyashpal deleted the patch-1 branch November 26, 2022 20:52
@goyalyashpal
Copy link
Contributor Author

I renamed the branch, per the instructions in "APK-testing" section in description, and now github thinks i deleted it, So, i opened the new #9471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Meta] Image-minimizer wrong behaviour
2 participants