Changed Help to Fast mode
#9498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stypox
requested changes
Dec 4, 2022
app/src/main/res/values/strings.xml
Outdated
| @@ -213,6 +213,7 @@ | |||
| <string name="delete_search_history_alert">Delete entire search history?</string> | |||
| <string name="search_history_deleted">Search history deleted</string> | |||
| <string name="help">Help</string> | |||
There was a problem hiding this comment.
You should remove the "Help" string completely (in all language files), unless it's used in some other place.
There was a problem hiding this comment.
It has only one instance, so I removed it from all language files.
pratyaksh1610
force-pushed
the
branch-9348
branch
from
ccc88c6 to
730664e
Compare
|
@Stypox I am creating a new PR , I forgot to rebase. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Changed "help" to "Fast mode" in three dot menu on what's new feed kiosk to make it self explanatory.
Before/After Screenshots/Screen Record
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence